Skip to content

Conversation

@BasPH
Copy link
Contributor

@BasPH BasPH commented Mar 14, 2020

Encountered (what I think is) a typo; "openfaas" was spelled "openfass" in the new package structure.


Issue link: AIRFLOW-7061

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #7721 into master will increase coverage by 22.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7721       +/-   ##
===========================================
+ Coverage   64.49%   86.70%   +22.21%     
===========================================
  Files         910      911        +1     
  Lines       44071    44084       +13     
===========================================
+ Hits        28422    38225     +9803     
+ Misses      15649     5859     -9790     
Impacted Files Coverage Δ
airflow/providers/openfaas/hooks/openfaas.py 94.11% <ø> (ø)
airflow/contrib/hooks/openfaas_hook.py 100.00% <100.00%> (+100.00%) ⬆️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0.00%> (-64.16%) ⬇️
airflow/providers/mysql/operators/mysql.py 55.00% <0.00%> (-45.00%) ⬇️
airflow/providers/apache/hive/hooks/hive.py 76.02% <0.00%> (-1.54%) ⬇️
airflow/utils/sqlalchemy.py 80.51% <0.00%> (-1.30%) ⬇️
airflow/bin/airflow 84.61% <0.00%> (ø)
airflow/providers/google/cloud/operators/vision.py 99.63% <0.00%> (+0.36%) ⬆️
...osoft/azure/operators/azure_container_instances.py 78.14% <0.00%> (+0.66%) ⬆️
airflow/providers/postgres/hooks/postgres.py 94.36% <0.00%> (+1.40%) ⬆️
... and 494 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc020c...8550889. Read the comment docs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Openfass :) indeed, not the best name ....

@potiuk potiuk merged commit 5f784ae into apache:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants