[AIRFLOW-5610] Add ability to specify multiple objects to copy in GCSToGCSOperator#7728
[AIRFLOW-5610] Add ability to specify multiple objects to copy in GCSToGCSOperator#7728potiuk merged 6 commits intoapache:masterfrom ephraimbuddy:gcs
Conversation
There was a problem hiding this comment.
should be List [str] or str
But maybe it would be better to keep both source_object and source_objects parameters (source_object = str, source_objects=List[str]) and check that only one is set?
I think that would be still backwards compatible, but more "accurate" with naming.
But I leave it up to you - I am ok with both approaches (as long as we have correct type).
There was a problem hiding this comment.
Nice. I'll take that approach of source_object and source_objects. Thanks a lot
Codecov Report
@@ Coverage Diff @@
## master #7728 +/- ##
===========================================
- Coverage 86.99% 59.90% -27.10%
===========================================
Files 915 915
Lines 44198 44228 +30
===========================================
- Hits 38451 26494 -11957
- Misses 5747 17734 +11987
Continue to review full report at Codecov.
|
|
Thanks @ephraimbuddy ! |
Issue link: AIRFLOW-5610
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.