Remove JIRA requirements from PRs#7771
Merged
kaxil merged 3 commits intoapache:masterfrom Mar 19, 2020
Merged
Conversation
As a part of our move from JIRA tickets to github issues, we should no longer force users to add JIRA ticket numbers to the titles of their PRs
dimberman
force-pushed
the
AIRFLOW-7094_github-actions
branch
from
6b34ebd to
2a9664f
Compare
ashb
reviewed
Mar 19, 2020
| matchers: | ||
| jiraIssueMatch: | ||
| titleIssueIdRegexp: \[(AIRFLOW-[0-9]{4})\] | ||
| descriptionIssueLink: "[${1}](https://issues.apache.org/jira/browse/${1})" |
Member
There was a problem hiding this comment.
@kaxil is it safe to leave this block in for our transition period where people still might be targeting Jiras?
Member
There was a problem hiding this comment.
Yes, it is safe. If it doesn't find the Jira in the title it won't do anything. However we need to remove verifyTitles block
kaxil
reviewed
Mar 19, 2020
ashb
added a commit
to ashb/airflow
that referenced
this pull request
Mar 20, 2020
Follow up to apache#7771, where we missed one final check
5 tasks
kaxil
pushed a commit
that referenced
this pull request
Mar 20, 2020
Follow up to #7771, where we missed one final check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of our move from JIRA tickets to github issues, we should no
longer force users to add JIRA ticket numbers to the titles of their PRs
Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.