Improve support for latest API in MLEngineStartTrainingJobOperator#7812
Merged
potiuk merged 1 commit intoapache:masterfrom Mar 23, 2020
Merged
Improve support for latest API in MLEngineStartTrainingJobOperator#7812potiuk merged 1 commit intoapache:masterfrom
potiuk merged 1 commit intoapache:masterfrom
Conversation
boring-cyborg
bot
added
the
provider:google
mik-laj
commented
Mar 23, 2020
| existing_training_input = existing_job.get('trainingInput', None) | ||
| requested_training_input = training_request['trainingInput'] | ||
| if 'scaleTier' not in existing_training_input: | ||
| existing_training_input['scaleTier'] = None |
Member
Author
There was a problem hiding this comment.
The API has stopped returning fields that are empty.
Member
Author
There was a problem hiding this comment.
This is a change in the remote API, so it cannot be detected by unit testing.
Codecov Report
@@ Coverage Diff @@
## master #7812 +/- ##
==========================================
- Coverage 86.91% 86.59% -0.33%
==========================================
Files 925 925
Lines 44873 44879 +6
==========================================
- Hits 39003 38862 -141
- Misses 5870 6017 +147
Continue to review full report at Codecov.
|
potiuk
approved these changes
Mar 23, 2020
kaxil
changed the title
kaxil
approved these changes
Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.