Skip to content

Add not solved items to pylint_todo.txt#7854

Closed
j-y-matsubara wants to merge 1 commit intoapache:masterfrom
j-y-matsubara:dev-airflow
Closed

Add not solved items to pylint_todo.txt#7854
j-y-matsubara wants to merge 1 commit intoapache:masterfrom
j-y-matsubara:dev-airflow

Conversation

@j-y-matsubara
Copy link
Contributor

This files do not pass pylint


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • [ x ] Description above provides context of the change
  • [ x ] Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • [ x ] Unit tests coverage for changes (not needed for documentation changes)
  • [ x ] Commits follow "How to write a good git commit message"
  • [ x ] Relevant documentation is updated including usage instructions.
  • [ x ] I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 24, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@potiuk
Copy link
Member

potiuk commented Mar 24, 2020

The general approach is that we should fix them rather than add to pylint_todo.txt -> pylint_todo.txt was only supposed to shrink, not grow. can you please fixe those files @j-y-matsubara ? that would be fantastic.

@j-y-matsubara
Copy link
Contributor Author

@potiuk
OK, I understand. I will try it.

The reason I sent this pull request is because when I ran scripts/ci/ci_pylint_main.sh, these items were marked as pylint errors.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments