Skip to content

Remove GKEStartPodOperator when backporting#7908

Merged
potiuk merged 3 commits intoapache:masterfrom
PolideaInternal:backport-gke-system-test
Mar 29, 2020
Merged

Remove GKEStartPodOperator when backporting#7908
potiuk merged 3 commits intoapache:masterfrom
PolideaInternal:backport-gke-system-test

Conversation

@turbaszek
Copy link
Member


Issue link: WILL BE INSERTED BY boring-cyborg

Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Mar 27, 2020
@turbaszek turbaszek requested a review from mik-laj March 27, 2020 17:34
@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #7908 into master will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7908      +/-   ##
==========================================
- Coverage   87.06%   86.90%   -0.17%     
==========================================
  Files         929      932       +3     
  Lines       45028    45187     +159     
==========================================
+ Hits        39205    39270      +65     
- Misses       5823     5917      +94     
Impacted Files Coverage Δ
...ud/example_dags/example_kubernetes_engine_setup.py 100.00% <100.00%> (ø)
airflow/kubernetes/volume_mount.py 44.44% <0.00%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0.00%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0.00%> (-45.08%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.69% <0.00%> (-25.26%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0.00%> (-23.53%) ⬇️
airflow/secrets/base_secrets.py 89.47% <0.00%> (-4.65%) ⬇️
airflow/www/views.py 76.58% <0.00%> (-0.12%) ⬇️
airflow/exceptions.py 100.00% <0.00%> (ø)
airflow/models/variable.py 93.33% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc631e...458b6ba. Read the comment docs.

@turbaszek turbaszek requested a review from potiuk March 29, 2020 09:35
@potiuk potiuk merged commit 0f19a93 into apache:master Mar 29, 2020
@mik-laj
Copy link
Member

mik-laj commented Mar 29, 2020

Hi. I thought about it longer and I think it should not be a problem to use the operators from airflow.contrib in Airflow 1.10. That way, we won't have to have a separate example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants