Call delete_dag on subdag without AttributeError#8017
Merged
dimberman merged 1 commit intoapache:masterfrom Apr 2, 2020
Merged
Call delete_dag on subdag without AttributeError#8017dimberman merged 1 commit intoapache:masterfrom
dimberman merged 1 commit intoapache:masterfrom
Conversation
The DagRun object does not have a task_id attribute, DagRuns are deleted in the block above so no need to do it here or remove ones belonging to the parent.
robinedwards
force-pushed
the
hotfix/delete-dag-experimental-api
branch
from
9f91bef to
759d960
Compare
dimberman
approved these changes
Apr 2, 2020
Contributor
dimberman
left a comment
dimberman
left a comment
There was a problem hiding this comment.
LGTM thank you @robinedwards !
Contributor
Author
|
Woohoo thank you :-) Would it be possible to get this into 1.10.10?
…On Thu, 2 Apr 2020, 19:48 Daniel Imberman, ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM thank you @robinedwards <https://github.com/robinedwards> !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8017 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHIYOVEKQWADBSVYPWQBLRKTMYPANCNFSM4LWWIHAQ>
.
|
Contributor
|
Should be, dont think we've done a code freeze yet :) |
|
Did this ever got included in 1.10.x? We get AttributeError that's fixed by this PR in 1.10.13 :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a subdag through the experimental api causes an
AttributeErroras aDagRundoesn't have a task_id column. DagRun's are handled prior to the subdag if statement so there is no need to remove them here. I also doubt we wanted to remove the parent dags DagRuns when removing a DagRun.I have adapted the existing test class a bit to avoid repetition and added a case which exercises the above issue.
Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.