Add support for GitHub registry cache#8497
Merged
potiuk merged 1 commit intoapache:masterfrom Apr 22, 2020
Merged
Conversation
This was referenced Apr 21, 2020
potiuk
force-pushed
the
add-support-for-github-registry-cache
branch
from
cf23a45 to
82d2383
Compare
potiuk
commented
Apr 21, 2020
potiuk
commented
Apr 21, 2020
potiuk
force-pushed
the
add-support-for-github-registry-cache
branch
from
82d2383 to
ea8463b
Compare
kaxil
reviewed
Apr 21, 2020
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Don't know much about Docker Caching. Can someone else review this PR please @dimberman @turbaszek
potiuk
force-pushed
the
add-support-for-github-registry-cache
branch
from
ea8463b to
ddfc176
Compare
turbaszek
reviewed
Apr 22, 2020
turbaszek
reviewed
Apr 22, 2020
potiuk
force-pushed
the
add-support-for-github-registry-cache
branch
from
ddfc176 to
5559c8e
Compare
turbaszek
reviewed
Apr 22, 2020
turbaszek
approved these changes
Apr 22, 2020
Member
turbaszek
left a comment
turbaszek
left a comment
There was a problem hiding this comment.
Small comment but otherwise looks good
potiuk
force-pushed
the
add-support-for-github-registry-cache
branch
from
5559c8e to
3b02715
Compare
potiuk
force-pushed
the
add-support-for-github-registry-cache
branch
from
3b02715 to
11ff8c4
Compare
potiuk
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Apr 22, 2020
Because of our unstable Travis we merged a failing build with apache#8512 and apache#8515 :(
potiuk
added a commit
that referenced
this pull request
Apr 26, 2020
(cherry picked from commit 887dea3)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
(cherry picked from commit 887dea3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE TO REVIEWERS! This one is based on top of #8496 so only review the last commit.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.