Conversation
We have documentation about credentials in system tests: The best solution is to add a marker that will skip the tests if the file with credentials is not available. If you try to run tests for GCP and you do not have credentials then you will see the message below: |
@mik-laj Thanks for the suggestion. I took a look at the marker you mention, it needs to copy the credentials in the What do you think? |
|
@xinbinhuang I agree. We don't need it now, but you asked how to make the documentation. The best documentation is an intuitive program that has user-friendly messages |
|
cc @feluelle @mustafagok - Feel free to take a look :) @feluelle I can rebase on your changes once your PR is merged into master |
feluelle
left a comment
There was a problem hiding this comment.
Please add emr.rst docs in the howto section. Besides that LGTM.
And if you PR is merged first I can rebase onto your changes (aws_system_helpers.py) - that's not a problem - you don't have to wait for my PR to be merged :)
|
@xinbinhuang you can rebase onto latest master. The |
66de32e to
7cc7f4c
Compare
|
@mustafagok @feluelle Sorry for the late update, I have been swamped by other things in the last two weeks. I update the PR with your suggestions. PTAL :) |
|
@feluelle @mustafagok Thanks for reviewing and merging! |
|
Fantastics! Thanks @feluelle ! |
Add system tests for two EMR related example DAGs.
The credentials are provided from
~/.aws/following as in boto3 configuration. I feel like I should add some docs somewhere to indicate how to provide credentials for the system test, but not sure where... Please let me know if you would like me to add the documentation somewhere.Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.