Remove _get_pretty_exception_message in PrestoHook#8677
Merged
mik-laj merged 1 commit intoapache:masterfrom May 3, 2020
Merged
Remove _get_pretty_exception_message in PrestoHook#8677mik-laj merged 1 commit intoapache:masterfrom
mik-laj merged 1 commit intoapache:masterfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Contributor
Author
|
BTW, I got a strange error for pre-commit which complains I don't have gnu installed which I actually did: echo $PATH
/usr/local/opt/gnu-getopt/bin:/Users/fusuiyi/opt/anaconda3/envs/airflow/bin:/Users/fusuiyi/opt/anaconda3/condabin:/Users/fusuiyi/Downloads/google-cloud-sdk/bin:/Users/fusuiyi/Downloads/apache-maven-3.5.4/bin:/Users/fusuiyi/Downloads/mongodb/bin:/usr/local/mysql/bin:/usr/local/opt/scala@2.11/bin:/usr/local/opt/sbt@0.13/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/fusuiyi/opt/anaconda3/bin:/Users/fusuiyi/opt/anaconda3/condabin:/Users/fusuiyi/Downloads/google-cloud-sdk/bin:/Users/fusuiyi/Downloads/apache-maven-3.5.4/bin:/Users/fusuiyi/Downloads/mongodb/bin:/usr/local/mysql/bin:/usr/local/opt/scala@2.11/bin:/usr/local/opt/sbt@0.13/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/Users/fusuiyi/.fzf/bingit commit
You are running pre_commit_ci_build.sh in OSX environment
And you need to install gnu commands
Run 'brew install gnu-getopt coreutils'
Then link the gnu-getopt to become default as suggested by brew.
If you use bash, you should run this command:
echo 'export PATH="/usr/local/opt/gnu-getopt/bin:$PATH"' >> ~/.bash_profile
. ~/.bash_profile
If you use zsh, you should run this command:
echo 'export PATH="/usr/local/opt/gnu-getopt/bin:$PATH"' >> ~/.zprofile
. ~/.zprofile
Login and logout afterwards !!
After re-login, your PATH variable should start with "/usr/local/opt/gnu-getopt/bin"
Your current path is /usr/local/git/libexec/git-core:/usr/local/opt/gnu-getopt/bin:/Users/fusuiyi/opt/anaconda3/envs/airflow/bin:/Users/fusuiyi/opt/anaconda3/condabin:/Users/fusuiyi/Downloads/google-cloud-sdk/bin:/Users/fusuiyi/Downloads/apache-maven-3.5.4/bin:/Users/fusuiyi/Downloads/mongodb/bin:/usr/local/mysql/bin:/usr/local/opt/scala@2.11/bin:/usr/local/opt/sbt@0.13/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/fusuiyi/opt/anaconda3/bin:/Users/fusuiyi/opt/anaconda3/condabin:/Users/fusuiyi/Downloads/google-cloud-sdk/bin:/Users/fusuiyi/Downloads/apache-maven-3.5.4/bin:/Users/fusuiyi/Downloads/mongodb/bin:/usr/local/mysql/bin:/usr/local/opt/scala@2.11/bin:/usr/local/opt/sbt@0.13/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/Users/fusuiyi/.fzf/bin |
mik-laj
approved these changes
May 3, 2020
|
Awesome work, congrats on your first merged pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #8530
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.