Skip to content

Comments

Remove _get_pretty_exception_message in PrestoHook#8677

Merged
mik-laj merged 1 commit intoapache:masterfrom
fusuiyi123:remove_get_pretty_exception_message
May 3, 2020
Merged

Remove _get_pretty_exception_message in PrestoHook#8677
mik-laj merged 1 commit intoapache:masterfrom
fusuiyi123:remove_get_pretty_exception_message

Conversation

@fusuiyi123
Copy link
Contributor

@fusuiyi123 fusuiyi123 commented May 2, 2020

Issue: #8530


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg
Copy link

boring-cyborg bot commented May 2, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@fusuiyi123
Copy link
Contributor Author

BTW, I got a strange error for pre-commit which complains I don't have gnu installed which I actually did:

echo $PATH
/usr/local/opt/gnu-getopt/bin:/Users/fusuiyi/opt/anaconda3/envs/airflow/bin:/Users/fusuiyi/opt/anaconda3/condabin:/Users/fusuiyi/Downloads/google-cloud-sdk/bin:/Users/fusuiyi/Downloads/apache-maven-3.5.4/bin:/Users/fusuiyi/Downloads/mongodb/bin:/usr/local/mysql/bin:/usr/local/opt/scala@2.11/bin:/usr/local/opt/sbt@0.13/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/fusuiyi/opt/anaconda3/bin:/Users/fusuiyi/opt/anaconda3/condabin:/Users/fusuiyi/Downloads/google-cloud-sdk/bin:/Users/fusuiyi/Downloads/apache-maven-3.5.4/bin:/Users/fusuiyi/Downloads/mongodb/bin:/usr/local/mysql/bin:/usr/local/opt/scala@2.11/bin:/usr/local/opt/sbt@0.13/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/Users/fusuiyi/.fzf/bin
git commit

You are running pre_commit_ci_build.sh in OSX environment
And you need to install gnu commands

Run 'brew install gnu-getopt coreutils'

Then link the gnu-getopt to become default as suggested by brew.

If you use bash, you should run this command:

echo 'export PATH="/usr/local/opt/gnu-getopt/bin:$PATH"' >> ~/.bash_profile
. ~/.bash_profile

If you use zsh, you should run this command:

echo 'export PATH="/usr/local/opt/gnu-getopt/bin:$PATH"' >> ~/.zprofile
. ~/.zprofile

Login and logout afterwards !!

After re-login, your PATH variable should start with "/usr/local/opt/gnu-getopt/bin"
Your current path is /usr/local/git/libexec/git-core:/usr/local/opt/gnu-getopt/bin:/Users/fusuiyi/opt/anaconda3/envs/airflow/bin:/Users/fusuiyi/opt/anaconda3/condabin:/Users/fusuiyi/Downloads/google-cloud-sdk/bin:/Users/fusuiyi/Downloads/apache-maven-3.5.4/bin:/Users/fusuiyi/Downloads/mongodb/bin:/usr/local/mysql/bin:/usr/local/opt/scala@2.11/bin:/usr/local/opt/sbt@0.13/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/fusuiyi/opt/anaconda3/bin:/Users/fusuiyi/opt/anaconda3/condabin:/Users/fusuiyi/Downloads/google-cloud-sdk/bin:/Users/fusuiyi/Downloads/apache-maven-3.5.4/bin:/Users/fusuiyi/Downloads/mongodb/bin:/usr/local/mysql/bin:/usr/local/opt/scala@2.11/bin:/usr/local/opt/sbt@0.13/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/Users/fusuiyi/.fzf/bin

@mik-laj mik-laj changed the title Remove _get_pretty_exception_message Remove _get_pretty_exception_message in PrestoHook May 3, 2020
@mik-laj mik-laj merged commit 1100cea into apache:master May 3, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 3, 2020

Awesome work, congrats on your first merged pull request!

@fusuiyi123 fusuiyi123 deleted the remove_get_pretty_exception_message branch May 3, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants