Skip to content

Comments

Relax Flask-Appbuilder version to ~=2.3.4#8857

Merged
kaxil merged 1 commit intoapache:masterfrom
feluelle:dependency/pin-fab
May 13, 2020
Merged

Relax Flask-Appbuilder version to ~=2.3.4#8857
kaxil merged 1 commit intoapache:masterfrom
feluelle:dependency/pin-fab

Conversation

@feluelle
Copy link
Member

"Bump jQuery to 3.5" was reverted. And so we can upgrade and remove email_validator dependency
See also: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/CHANGELOG.rst#improvements-and-bug-fixes-on-234


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the CI passes :)

@feluelle
Copy link
Member Author

Assuming the CI passes :)

Yes, let's see :)

@feluelle feluelle changed the title Pin Flask-Appbuilder to 2.3.4 Release Flask-Appbuilder to >=2.3.4 and <3 May 13, 2020
@feluelle feluelle changed the title Release Flask-Appbuilder to >=2.3.4 and <3 Relax Flask-Appbuilder version to >=2.3.4 and <3 May 13, 2020
@feluelle
Copy link
Member Author

feluelle commented May 13, 2020

@kaxil if it passes can you (or I do) change the commit msg to an appropiate one. :) Thanks. Maybe Relax Flask-Appbuilder version to ~=2.3.4 and include the rest of the first commit's body.

@feluelle feluelle changed the title Relax Flask-Appbuilder version to >=2.3.4 and <3 Relax Flask-Appbuilder version to ~=2.3.4 May 13, 2020
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but you will have to run generate-requirements to update the md5 of hash after you changed setup.py @feluelle - for both python 3.6 and 3.7

@feluelle
Copy link
Member Author

It's fine, but you will have to run generate-requirements to update the md5 of hash after you changed setup.py @feluelle - for both python 3.6 and 3.7

Thanks - will do.

@feluelle
Copy link
Member Author

I get a weird error when trying to build the image locally with breeze and also on travis:

Err:224 http://ftp.us.debian.org/debian sid/main amd64 vim-runtime all 2:8.2.0716-3
  Undetermined Error [IP: 208.80.154.15 80]
Get:225 http://ftp.us.debian.org/debian sid/main amd64 vim amd64 2:8.2.0716-3 [1363 kB]
Fetched 197 MB in 1min 29s (2208 kB/s)
E: Failed to fetch http://ftp.us.debian.org/debian/pool/main/v/vim/vim-runtime_8.2.0716-3_all.deb  Undetermined Error [IP: 208.80.154.15 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
The command '/bin/bash -o pipefail -e -u -x -c mkdir -pv /usr/share/man/man1     && mkdir -pv /usr/share/man/man7     && echo "deb http://ftp.us.debian.org/debian sid main"         > /etc/apt/sources.list.d/openjdk.list     && apt-get update     && apt-get install --no-install-recommends -y       gnupg       libgcc-8-dev       openjdk-8-jdk       apt-transport-https       bash-completion       ca-certificates       software-properties-common       krb5-user       ldap-utils       less       libpython2.7-stdlib       lsb-release       net-tools       openssh-client       openssh-server       postgresql-client       sqlite3       tmux       unzip       vim     && apt-get autoremove -yqq --purge     && apt-get clean     && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100

@feluelle feluelle changed the title Relax Flask-Appbuilder version to ~=2.3.4 [WIP] Relax Flask-Appbuilder version to ~=2.3.4 May 13, 2020
@potiuk
Copy link
Member

potiuk commented May 13, 2020

I get a weird error when trying to build the image locally with breeze and also on travis:

Likely an intermittent error with contacting the server (network connectivity problem)

@feluelle
Copy link
Member Author

Jarek, do I have to rebuild the CI image when generating requriements or is it fine if I say n? This takes really long 😁

"Bump jQuery to 3.5" was reverted. And so we can upgrade and remove email_validator dependency
See also: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/CHANGELOG.rst#improvements-and-bug-fixes-on-234
@feluelle feluelle force-pushed the dependency/pin-fab branch from 659618d to e62dc68 Compare May 13, 2020 14:28
@feluelle feluelle changed the title [WIP] Relax Flask-Appbuilder version to ~=2.3.4 Relax Flask-Appbuilder version to ~=2.3.4 May 13, 2020
@potiuk
Copy link
Member

potiuk commented May 13, 2020

Yes. you have to. The really long rebuild is because you changed EPOCH and removed requirement):

But you can do it ./breeze --force-pull to force pulling image first - then it should rebuild only from the point of changed setup.py.

In your case (EPOCH changed and removed dependencies) it takes really long because we have to run the whole installation from the scratch - all 140 or so packages should be downloaded installed (and some of them compiled)

In most other cases (just modifying setup.py) it's much faster.

@feluelle
Copy link
Member Author

@kaxil @potiuk I think it is ready. The one that failed is a Quarantined one.

@kaxil kaxil merged commit 2878f17 into apache:master May 13, 2020
@feluelle feluelle deleted the dependency/pin-fab branch May 14, 2020 08:15
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jun 5, 2020
@kaxil
Copy link
Member

kaxil commented Jun 5, 2020

Added to 1.10.11 milestone but that is conditional, I will check the compatibility with v1.10-test, if it is breaking something I won't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants