Relax Flask-Appbuilder version to ~=2.3.4#8857
Conversation
Yes, let's see :) |
|
@kaxil if it passes can you (or I do) change the commit msg to an appropiate one. :) Thanks. Maybe |
Thanks - will do. |
|
I get a weird error when trying to build the image locally with breeze and also on travis: |
Likely an intermittent error with contacting the server (network connectivity problem) |
|
Jarek, do I have to rebuild the CI image when generating requriements or is it fine if I say |
"Bump jQuery to 3.5" was reverted. And so we can upgrade and remove email_validator dependency See also: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/CHANGELOG.rst#improvements-and-bug-fixes-on-234
659618d to
e62dc68
Compare
|
Yes. you have to. The really long rebuild is because you changed EPOCH and removed requirement): But you can do it In your case (EPOCH changed and removed dependencies) it takes really long because we have to run the whole installation from the scratch - all 140 or so packages should be downloaded installed (and some of them compiled) In most other cases (just modifying setup.py) it's much faster. |
|
Added to 1.10.11 milestone but that is conditional, I will check the compatibility with v1.10-test, if it is breaking something I won't |
"Bump jQuery to 3.5" was reverted. And so we can upgrade and remove email_validator dependency
See also: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/CHANGELOG.rst#improvements-and-bug-fixes-on-234
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.