Skip to content

Updated missing parameters for docker image building #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
turbaszek merged 1 commit into from
Jun 2, 2020
Merged

Updated missing parameters for docker image building #9039

turbaszek merged 1 commit into from
Jun 2, 2020

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented May 27, 2020

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member Author

potiuk commented May 27, 2020

cc @wittfabian

@potiuk potiuk requested a review from dimberman May 27, 2020 17:53
@potiuk potiuk assigned kaxil and unassigned kaxil May 27, 2020
@potiuk potiuk requested review from mik-laj and turbaszek May 27, 2020 17:54
@potiuk potiuk force-pushed the doc-update-for-images branch from 8ecdaa0 to 80718ac Compare June 2, 2020 06:18
@potiuk
Copy link
Member Author

potiuk commented Jun 2, 2020

@turbaszek @mik-laj -> simple doc change please :)

@turbaszek turbaszek merged commit b7b4846 into apache:master Jun 2, 2020
@turbaszek turbaszek deleted the doc-update-for-images branch June 2, 2020 07:27
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 20, 2020
@potiuk potiuk added this to the Airflow 1.10.11 milestone Jun 20, 2020
potiuk added a commit that referenced this pull request Jun 20, 2020
@potiuk
Updated missing parameters for docker image building (#9039)
c7bca9d 
(cherry picked from commit b7b4846)
potiuk added a commit that referenced this pull request Jun 29, 2020
@potiuk
Updated missing parameters for docker image building (#9039)
4dbe69c 
(cherry picked from commit b7b4846)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
@potiuk @kaxil
Updated missing parameters for docker image building (#9039)
d4328d5 
(cherry picked from commit b7b4846)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@potiuk
Updated missing parameters for docker image building (apache#9039)
360211b 
(cherry picked from commit b7b4846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turbaszek turbaszek turbaszek approved these changes

@mik-laj mik-laj mik-laj approved these changes

@dimberman dimberman Awaiting requested review from dimberman

Assignees

No one assigned

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Milestone

Airflow 1.10.11

Development

Successfully merging this pull request may close these issues.

4 participants

@potiuk @turbaszek @mik-laj @kaxil