Don't reuse MY_DIR in breeze to mean different folder from ci/_utils.sh#9098
Merged
potiuk merged 1 commit intoapache:masterfrom Jun 2, 2020
Merged
Don't reuse MY_DIR in breeze to mean different folder from ci/_utils.sh#9098potiuk merged 1 commit intoapache:masterfrom
potiuk merged 1 commit intoapache:masterfrom
Conversation
scripts/ci/*.sh uses MY_DIR to mean scripts/ci, but in `breeze` MY_DIR is the same as AIRFLOW_SOURCES. When jumping back-and-forth between ci/_utils.sh, breeze, and ci/ci_*.sh it can be confusing to keep track of what is what. This changes `breeze` to use `AIRFLOW_SOURCES` to referrer to the top level folder instead -- that means I don't have to keep as much context in my head
potiuk
approved these changes
Jun 2, 2020
potiuk
pushed a commit
that referenced
this pull request
Jun 9, 2020
…sh (#9098) scripts/ci/*.sh uses MY_DIR to mean scripts/ci, but in `breeze` MY_DIR is the same as AIRFLOW_SOURCES. When jumping back-and-forth between ci/_utils.sh, breeze, and ci/ci_*.sh it can be confusing to keep track of what is what. This changes `breeze` to use `AIRFLOW_SOURCES` to referrer to the top level folder instead -- that means I don't have to keep as much context in my head (cherry picked from commit 3dd81b7)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
…sh (#9098) scripts/ci/*.sh uses MY_DIR to mean scripts/ci, but in `breeze` MY_DIR is the same as AIRFLOW_SOURCES. When jumping back-and-forth between ci/_utils.sh, breeze, and ci/ci_*.sh it can be confusing to keep track of what is what. This changes `breeze` to use `AIRFLOW_SOURCES` to referrer to the top level folder instead -- that means I don't have to keep as much context in my head (cherry picked from commit 3dd81b7)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…sh (apache#9098) scripts/ci/*.sh uses MY_DIR to mean scripts/ci, but in `breeze` MY_DIR is the same as AIRFLOW_SOURCES. When jumping back-and-forth between ci/_utils.sh, breeze, and ci/ci_*.sh it can be confusing to keep track of what is what. This changes `breeze` to use `AIRFLOW_SOURCES` to referrer to the top level folder instead -- that means I don't have to keep as much context in my head (cherry picked from commit 3dd81b7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/ci/*.sh uses
MY_DIRto mean scripts/ci, but inbreezeMY_DIRis the same as AIRFLOW_SOURCES. When jumping back-and-forth between
ci/utils.sh, breeze, and ci/ci*.sh it can be confusing to keep track
of what is what.
This changes
breezeto useAIRFLOW_SOURCESto referrer to the toplevel folder instead -- that means I don't have to keep as much context
in my head. I realise the MY_DIR was just "the folder of the script", but for some reason this was confusing my in breeze where AIRFLOW_SOURCES already existed.
In doing this I noticed a small "bug" -- we were creating ./scripts/ci/.kube folder for pre-commit runs.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.