Move TestDagFileProcessorQueriesCount to quarantine#9119
Merged
mik-laj merged 1 commit intoapache:masterfrom Jun 3, 2020
Merged
Move TestDagFileProcessorQueriesCount to quarantine#9119mik-laj merged 1 commit intoapache:masterfrom
mik-laj merged 1 commit intoapache:masterfrom
Conversation
Member
|
@mik-laj this "time-related" problem is something I observed too |
turbaszek
approved these changes
Jun 3, 2020
Member
|
Seems odd at first glance that sorting a list in python would change the number of queries... 🤔 I wonder what's going on here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to repeat this problem locally, but I still need some time to investigate the cause.It may be related to this line:
airflow/airflow/jobs/scheduler_job.py
Line 692 in 10796cb
When I do the following changes in this file, this issue doesn't happent.
# update the state of the previously active dag runs active_dag_runs = 0 task_instances_list = [] - for run in dag_runs: + for run in sorted(dag_runs, key=lambda d: d.execution_date): self.log.info("Examining DAG run %s", run) # don't consider runs that are executed in the future unless # specified by config and schedule_interval is NoneI am not sure if this is a good solution.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.