Skip to content

Split utils sh#9132

Merged
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:split_utils_sh
Jun 4, 2020
Merged

Split utils sh#9132
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:split_utils_sh

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 4, 2020

Please take a look at the last commit. It is based on #9130


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backward-incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member Author

potiuk commented Jun 4, 2020

Following the discussion with @dimberman (and recent slack conversation with @ashb about utils as being bad name) -> I split the _utils.sh into meaningful and much smaller libraries - each responsible for pretty much one thing only.

It should be much easier to understand what's going on and where to search for corresponding part of the bash script. If we ever decide to reimplement some parts of it in a different languages, that might also be good idea to understand what Breeze and the scripts are actually doing.

@potiuk potiuk force-pushed the split_utils_sh branch 2 times, most recently from 18a513c to f2d97b3 Compare June 4, 2020 01:44
Copy link
Contributor

@dimberman dimberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @potiuk!

@dimberman
Copy link
Contributor

@potiuk we probably want to run all tests on this btw.

@potiuk
Copy link
Member Author

potiuk commented Jun 4, 2020

@potiuk we probably want to run all tests on this btw.

Good point. I updated the pattern in ci.yml to also trigger test builds on any change in "scripts" :).

@potiuk potiuk force-pushed the split_utils_sh branch 3 times, most recently from a831b45 to 5ca0d33 Compare June 4, 2020 18:02
@potiuk potiuk merged commit 92d6880 into apache:master Jun 4, 2020
@potiuk potiuk deleted the split_utils_sh branch June 4, 2020 20:12
@potiuk potiuk added this to the Airflow 1.10.11 milestone Jun 9, 2020
potiuk added a commit that referenced this pull request Jun 9, 2020
* Split _utils.sh into separate files

(cherry picked from commit 92d6880)
potiuk added a commit that referenced this pull request Jun 29, 2020
* Split _utils.sh into separate files

(cherry picked from commit 92d6880)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
* Split _utils.sh into separate files

(cherry picked from commit 92d6880)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
* Split _utils.sh into separate files

(cherry picked from commit 92d6880)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants