Merged
Conversation
Member
Author
|
Following the discussion with @dimberman (and recent slack conversation with @ashb about It should be much easier to understand what's going on and where to search for corresponding part of the bash script. If we ever decide to reimplement some parts of it in a different languages, that might also be good idea to understand what Breeze and the scripts are actually doing. |
18a513c to
f2d97b3
Compare
ashb
reviewed
Jun 4, 2020
ashb
reviewed
Jun 4, 2020
dimberman
approved these changes
Jun 4, 2020
Contributor
|
@potiuk we probably want to run all tests on this btw. |
Member
Author
Good point. I updated the pattern in ci.yml to also trigger test builds on any change in "scripts" :). |
a831b45 to
5ca0d33
Compare
potiuk
added a commit
that referenced
this pull request
Jun 9, 2020
* Split _utils.sh into separate files (cherry picked from commit 92d6880)
potiuk
added a commit
that referenced
this pull request
Jun 29, 2020
* Split _utils.sh into separate files (cherry picked from commit 92d6880)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
* Split _utils.sh into separate files (cherry picked from commit 92d6880)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Split _utils.sh into separate files (cherry picked from commit 92d6880)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please take a look at the last commit. It is based on #9130
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backward-incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.