Update pre-commit-hooks repo version#9195
Merged
kaxil merged 1 commit intoapache:masterfrom Jun 14, 2020
Merged
Conversation
feluelle
commented
Jun 9, 2020
.pre-commit-config.yaml
Outdated
Member
Author
There was a problem hiding this comment.
pre-commit/pre-commit-hooks now requires python3.6.1+
That is the only noticeable difference for us.
Ref: https://github.com/pre-commit/pre-commit-hooks/releases
.pre-commit-config.yaml
Outdated
Member
Author
There was a problem hiding this comment.
Fix version - I set it to the latest version.
.pre-commit-config.yaml
Outdated
Member
Author
There was a problem hiding this comment.
Fix version - I set it to the latest version.
potiuk
approved these changes
Jun 9, 2020
Member
|
It looks like the new stylelint requires some style improvements as well @feluelle |
turbaszek
approved these changes
Jun 9, 2020
Member
|
isort seems to be wreaking havok with the UPDATING.md -- we might have to not pick the latest version (or else turn it tune it down): diff --git a/docs/howto/operator/gcp/gcs_to_gcs.rst b/docs/howto/operator/gcp/gcs_to_gcs.rst
index e17bedf..bb3fda1 100644
--- a/docs/howto/operator/gcp/gcs_to_gcs.rst
+++ b/docs/howto/operator/gcp/gcs_to_gcs.rst
@@ -40,11 +40,9 @@ perform this task faster and more economically. The economic effects are especia
Airflow is not hosted in Google Cloud Platform, because these operators reduce egress traffic.
These operators modify source objects if the option that specifies whether objects should be deleted
-from the source after they are transferred to the sink is enabled.
When you use the Google Cloud Data Transfer service, you can specify whether overwriting objects that already exist in
the sink is allowed, whether objects that exist only in the sink should be deleted, or whether objects should be deleted
-from the source after they are transferred to the sink.
Source objects can be specified using include and exclusion prefixes, as well as based on the file
modification date.It seems to think any line starting with |
Member
Author
|
Thanks all - will fix the issues. |
Member
Author
- use official isort pre-commit-hook - use official yamllint pre-commit-hook - run isort pre-commit-hook on all python files instead of files ending with py
12db120 to
8718ecd
Compare
kaxil
approved these changes
Jun 14, 2020
potiuk
pushed a commit
that referenced
this pull request
Jun 20, 2020
- use official yamllint pre-commit-hook - run isort pre-commit-hook on all python files instead of files ending with py (cherry picked from commit 1698db4)
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
- use official yamllint pre-commit-hook - run isort pre-commit-hook on all python files instead of files ending with py (cherry picked from commit 1698db4)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
- use official yamllint pre-commit-hook - run isort pre-commit-hook on all python files instead of files ending with py (cherry picked from commit 1698db4)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
- use official yamllint pre-commit-hook - run isort pre-commit-hook on all python files instead of files ending with py (cherry picked from commit 1698db4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.