Skip to content

Correctly dump logs from init containers names on CI failure#9215

Closed
turbaszek wants to merge 1 commit intoapache:masterfrom
PolideaInternal:fix-k8s-logging-ci
Closed

Correctly dump logs from init containers names on CI failure#9215
turbaszek wants to merge 1 commit intoapache:masterfrom
PolideaInternal:fix-k8s-logging-ci

Conversation

@turbaszek
Copy link
Member

------- webserver init container logs - init -------
error: container init is not valid for pod airflow-594f8b87d-6ph6k

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. good catch. - just one left-over with commented lines.

@turbaszek turbaszek force-pushed the fix-k8s-logging-ci branch from f874660 to 79e9713 Compare June 10, 2020 18:44
@turbaszek
Copy link
Member Author

Hi @dimberman @potiuk it seems we have a problem with k8s ci builds:

psycopg2.OperationalError: could not translate host name "postgres-airflow" to address: Temporary failure in name resolution

@dimberman
Copy link
Contributor

@potiuk could this have to do with moving to host?

@turbaszek
Copy link
Member Author

This seems to be not related change but looking at commit history this problem persists since
#9207

@dimberman
Copy link
Contributor

@turbaszek please let me know if this is the solution. cc: @mik-laj.

@turbaszek turbaszek force-pushed the fix-k8s-logging-ci branch from 3a5ac5f to a71b21c Compare June 10, 2020 19:40
@turbaszek
Copy link
Member Author

turbaszek commented Jun 10, 2020

@dimberman as expected, this wasn't an issue. I've rebased to the first commit. Any ideas about what could have happened?

@turbaszek turbaszek marked this pull request as ready for review June 10, 2020 19:45
@turbaszek turbaszek requested a review from potiuk June 10, 2020 19:46
@ashb ashb changed the title Fix init containers names on CI Correctly dump logs from init containers names on CI failure Jun 10, 2020
@ashb
Copy link
Member

ashb commented Jun 11, 2020

I think with #9230 this isn't needed anymore

@turbaszek
Copy link
Member Author

@ashb do those artifacts include logs from pods' containers including inits?

@potiuk
Copy link
Member

potiuk commented Jun 11, 2020

Yep. Those are done with kind logs export (we had them before they were just not called after the recent refactor). 'kind export logs' export EVERYTHING. It's the debug feature of kind which is on its own debug version of Kubernetes cluster :)

@turbaszek turbaszek closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments