Skip to content

Mssql to oracle operator#9218

Closed
jkbngl wants to merge 3 commits intoapache:masterfrom
jkbngl:mssql-to-oracle-operator
Closed

Mssql to oracle operator#9218
jkbngl wants to merge 3 commits intoapache:masterfrom
jkbngl:mssql-to-oracle-operator

Conversation

@jkbngl
Copy link

@jkbngl jkbngl commented Jun 10, 2020


Make sure to mark the boxes below before creating PR: [x]

Added Operator to transfer data from MSSql to Oracle, building on top of oracleToOracleTransfer operator.

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes) -> Also needed for operator added? I dont see tests for all operators in the test folder
  • Target Github ISSUE in description if exists -> none created, seems optional
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions. -> should be auto generated, please let me know if I should provide documentation somewhere, I created an example Dag which uses my new operator, hope this is good aswell
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@jhtimmins
Copy link
Contributor

jhtimmins commented Jun 11, 2020

Looks like the static checks are failing. If you haven't, you can run the pre-commit hooks to make sure the static checks pass on your local machine.
https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks

@jkbngl
Copy link
Author

jkbngl commented Jun 14, 2020

@jhtimmins I will fix try to fix the issues from the failing checks and open a new pull request, thanks for the heads up

@jkbngl jkbngl closed this Jun 14, 2020
@jkbngl jkbngl deleted the mssql-to-oracle-operator branch June 14, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants