Skip to content

Move test_remove_unused_code to Quarantine#9268

Merged
mik-laj merged 1 commit intoapache:masterfrom
astronomer:dagcode-quarantine
Jun 13, 2020
Merged

Move test_remove_unused_code to Quarantine#9268
mik-laj merged 1 commit intoapache:masterfrom
astronomer:dagcode-quarantine

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Jun 13, 2020

This test is passing locally and on breeze. Not sure of a reason why it is failing on CI


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

This test is passing locally and on breeze. Not sure of a reason why it is failing on CI
@kaxil kaxil requested review from ashb and feluelle June 13, 2020 00:21
@kaxil kaxil changed the title Add test_remove_unused_code to Quarantined test Move test_remove_unused_code to Quarantine Jun 13, 2020
Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's a good idea to add non-working tests to quarantine. The quarantine should contain tests that do not behave stable and it is necessary to test their behavior before fixing them. However, this may be a workaround.

@mik-laj mik-laj merged commit 6b45136 into apache:master Jun 13, 2020
@kaxil kaxil deleted the dagcode-quarantine branch June 18, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants