Merged
Conversation
kaxil
force-pushed
the
add-airflow-github-script
branch
from
1ca1b53 to
c8e930c
Compare
kaxil
reviewed
Jun 13, 2020
dev/airflow-github
Outdated
Comment on lines
149
to
150
| if not commit: | ||
| continue |
Member
There was a problem hiding this comment.
Because of this the PRs/Issues that are not merged yet won't show in the list
kaxil
reviewed
Jun 13, 2020
dev/airflow-github
Outdated
Comment on lines
143
to
148
| for issue in milestone_issues: | ||
| commit = None | ||
| for event in issue.get_events(): | ||
| # Checks if event is a commit getting merged into master. | ||
| if event.event == 'merged': | ||
| commit = event.commit_id |
Member
There was a problem hiding this comment.
This loop is time-consuming, takes a good amount of time on my machine to load all commits.
- Fetch the commit in Master locally first without using Github API. - If not present, find the `merge_commit_sha` using the Github API
jhtimmins
commented
Jun 14, 2020
jhtimmins
force-pushed
the
add-airflow-github-script
branch
from
9ab8c72 to
a77f567
Compare
kaxil
approved these changes
Jun 14, 2020
kaxil
added a commit
that referenced
this pull request
Jun 17, 2020
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> (cherry picked from commit cef1df4)
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> (cherry picked from commit cef1df4)
kaxil
added a commit
that referenced
this pull request
Jul 1, 2020
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> (cherry picked from commit cef1df4)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> (cherry picked from commit cef1df4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Github counterpart to the airflow-jira script that generates comparisons between releases as well as changelogs.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.