Skip to content

Fix Failing test for JSON Formatter on Python 3.8#9278

Merged
kaxil merged 2 commits into
apache:masterfrom
astronomer:fix-es-py3.8
Jun 13, 2020
Merged

Fix Failing test for JSON Formatter on Python 3.8#9278
kaxil merged 2 commits into
apache:masterfrom
astronomer:fix-es-py3.8

Conversation

@kaxil
Copy link
Copy Markdown
Member

@kaxil kaxil commented Jun 13, 2020

This test is failing on Master:

tests/utils/log/test_es_task_handler.py ..................F

_ TestElasticsearchTaskHandler.test_set_context_w_json_format_and_write_stdout _

self = <tests.utils.log.test_es_task_handler.TestElasticsearchTaskHandler testMethod=test_set_context_w_json_format_and_write_stdout>

    def test_set_context_w_json_format_and_write_stdout(self):
        self.es_task_handler.formatter = mock.MagicMock()
        self.es_task_handler.formatter._fmt = mock.MagicMock()
        self.es_task_handler.formatter._fmt.find = mock.MagicMock(return_value=1)
        self.es_task_handler.write_stdout = True
        self.es_task_handler.json_format = True
>       self.es_task_handler.set_context(self.ti)

tests/utils/log/test_es_task_handler.py:262: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
airflow/utils/log/es_task_handler.py:210: in set_context
    self.formatter = JSONFormatter(
airflow/utils/log/json_formatter.py:35: in __init__
    super().__init__(fmt, datefmt, style)
/usr/local/lib/python3.8/logging/__init__.py:576: in __init__
    self._style.validate()

Also, there is no need of passing the default fmt value explicitly as it is the default.

cc @andriisoldatenko


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil
Copy link
Copy Markdown
Member Author

kaxil commented Jun 13, 2020

@andriisoldatenko Can you let me know if I am missing something here please

@kaxil kaxil merged commit 34d0c2d into apache:master Jun 13, 2020
@kaxil kaxil deleted the fix-es-py3.8 branch June 13, 2020 18:09
kaxil added a commit that referenced this pull request Jun 30, 2020
kaxil added a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants