Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Jun 14, 2020

This is faster, less verbose, and more readable.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

This is faster, less verbose, and more readable.
@kaxil kaxil requested a review from feluelle June 14, 2020 01:52
@mik-laj
Copy link
Member

mik-laj commented Jun 14, 2020

Should it be detected by pylint or other linter?

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faster might not be true - the interpreter may well treat these the same. It won't be slower toug though

@kaxil kaxil merged commit e148f34 into apache:master Jun 14, 2020
@kaxil kaxil deleted the DagBag-in branch June 14, 2020 11:48
@kaxil
Copy link
Member Author

kaxil commented Jun 14, 2020

Should it be detected by pylint or other linter?

Yup will take a look today on our pylint configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants