Skip to content

Comments

Fix broken CI image optimisation#9313

Merged
kaxil merged 1 commit intoapache:masterfrom
PolideaInternal:fix-broken-ci-image-build-optimisation
Jun 15, 2020
Merged

Fix broken CI image optimisation#9313
kaxil merged 1 commit intoapache:masterfrom
PolideaInternal:fix-broken-ci-image-build-optimisation

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 15, 2020

The commit 5918efc broke
optimisation of the CI image - using the Apache Airflow
master branch as base package installation source from pypi.

This commit restores it including removal of the
obsoltete CI_OPTIMISED arg - as now we have a separate
production and CI image and CI image is by default
CI_OPTIMISED


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

The commit 5918efc broke
optimisation of the CI image - using the Apache Airflow
master branch as base package installation source from pypi.

This commit restores it including removal of the
obsoltete CI_OPTIMISED arg - as now we have a separate
production and CI image and CI image is by default
CI_OPTIMISED
@potiuk
Copy link
Member Author

potiuk commented Jun 15, 2020

The 3.8 commit added +10 minutes for rebuild time whenever setup.py changes - both in CI and Breeze, so we better fix it .

@potiuk
Copy link
Member Author

potiuk commented Jun 15, 2020

I'd love to get that one fixed. It makes local rebuilds for changed setup run much slower than it should currently it always reinstalls all dependencies always from 0 which adds a lot of time for rebuilds/

@kaxil kaxil merged commit 696e745 into apache:master Jun 15, 2020
potiuk added a commit that referenced this pull request Jun 20, 2020
The commit 5918efc broke
optimisation of the CI image - using the Apache Airflow
master branch as a base package installation source from PyPI.

This commit restores it including removal of the
obsolete CI_OPTIMISED arg - as now we have a separate
production and CI image and CI image is by default
CI_OPTIMISED

(cherry picked from commit 696e745)
potiuk added a commit that referenced this pull request Jun 29, 2020
The commit 5918efc broke
optimisation of the CI image - using the Apache Airflow
master branch as a base package installation source from PyPI.

This commit restores it including removal of the
obsolete CI_OPTIMISED arg - as now we have a separate
production and CI image and CI image is by default
CI_OPTIMISED

(cherry picked from commit 696e745)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
The commit 5918efc broke
optimisation of the CI image - using the Apache Airflow
master branch as a base package installation source from PyPI.

This commit restores it including removal of the
obsolete CI_OPTIMISED arg - as now we have a separate
production and CI image and CI image is by default
CI_OPTIMISED

(cherry picked from commit 696e745)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
The commit 5918efc broke
optimisation of the CI image - using the Apache Airflow
master branch as a base package installation source from PyPI.

This commit restores it including removal of the
obsolete CI_OPTIMISED arg - as now we have a separate
production and CI image and CI image is by default
CI_OPTIMISED

(cherry picked from commit 696e745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants