Refactor CeleryExecutor to avoid duplication of code in test#9345
Merged
ashb merged 1 commit intoapache:masterfrom Jun 17, 2020
Merged
Refactor CeleryExecutor to avoid duplication of code in test#9345ashb merged 1 commit intoapache:masterfrom
ashb merged 1 commit intoapache:masterfrom
Conversation
The test code had duplicated most of the code in "trigger_tasks" -- meaning we weren't strictly speaking testing the executor anymore. This removes the duplicated code in the test by refactoring the method in the executor and calling that instead.
mik-laj
approved these changes
Jun 17, 2020
kaxil
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test code had duplicated most of the code in "trigger_tasks" --
meaning we weren't strictly speaking testing the executor anymore.
This removes the duplicated code in the test by refactoring the method
in the executor and calling that instead.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.