Skip to content

Comments

Refactor CeleryExecutor to avoid duplication of code in test#9345

Merged
ashb merged 1 commit intoapache:masterfrom
astronomer:refactor-celery-tests
Jun 17, 2020
Merged

Refactor CeleryExecutor to avoid duplication of code in test#9345
ashb merged 1 commit intoapache:masterfrom
astronomer:refactor-celery-tests

Conversation

@ashb
Copy link
Member

@ashb ashb commented Jun 17, 2020

The test code had duplicated most of the code in "trigger_tasks" --
meaning we weren't strictly speaking testing the executor anymore.

This removes the duplicated code in the test by refactoring the method
in the executor and calling that instead.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

The test code had duplicated most of the code in "trigger_tasks" --
meaning we weren't strictly speaking testing the executor anymore.

This removes the duplicated code in the test by refactoring the method
in the executor and calling that instead.
@ashb ashb requested review from kaxil and mik-laj June 17, 2020 12:09
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Jun 17, 2020
@ashb ashb merged commit 54667d1 into apache:master Jun 17, 2020
@ashb ashb deleted the refactor-celery-tests branch June 17, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants