Skip to content

Comments

Decouple parameters formatting and endpoint logic#9405

Merged
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:formaatters
Jun 19, 2020
Merged

Decouple parameters formatting and endpoint logic#9405
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:formaatters

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Jun 19, 2020

I separated the two operations to make the code easier to read and maintain. I hope that the library will be fixed and we will be able to delete this decorator.

CC: @ephraimbuddy


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jun 19, 2020
@mik-laj mik-laj requested a review from turbaszek June 19, 2020 12:22
Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@mik-laj mik-laj merged commit d7ef352 into apache:master Jun 19, 2020
@mik-laj mik-laj deleted the formaatters branch June 19, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants