Fix process_subdir bug#941
Merged
mistercrunch merged 1 commit intoapache:masterfrom Feb 1, 2016
Attsun1031:fix-process-subdir-bug
Merged
Fix process_subdir bug#941mistercrunch merged 1 commit intoapache:masterfrom Attsun1031:fix-process-subdir-bug
mistercrunch merged 1 commit intoapache:masterfrom
Attsun1031:fix-process-subdir-bug
Conversation
Member
|
Totally makes sense. I added the |
mobuchowski
pushed a commit
to mobuchowski/airflow
that referenced
this pull request
Jan 4, 2022
…dulum versions (apache#941) * Handling paths to files in older airflow versions and handling of pendulum older version Signed-off-by: Walter Hernandez <walter.hernandezcruz@mishcon.com> * Added specification of exception for import of Pendulum Signed-off-by: Walter Hernandez <walter.hernandezcruz@mishcon.com> Co-authored-by: Walter Hernandez <walter.hernandezcruz@mishcon.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If subdir parameter (
airflow runcommand) containsDAGS_FOLDERand the subdir is relative path,cli.process_subdirfailed to parse correclty, and could not find dag file.For example, if
DAGS_FOLDERis/var/lib/airflowand current directory is also/var/lib/airflow,DAGS_FOLDER/abcbecome/var/lib/airflow/var/lib/airflow/abc.This is because
os.path.abspathis called before replaceDAGS_FOLDERpalceholder.https://github.com/airbnb/airflow/blob/master/airflow/models.py#L630
This bug is critical because
TaskInstance.commadspecifyDAGS_FOLDER/{dag.filepath}as default suddir value.