Skip to content

Comments

Warn about incompatible plugins#9416

Merged
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:warn-plugins
Jun 19, 2020
Merged

Warn about incompatible plugins#9416
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:warn-plugins

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Jun 19, 2020

I suggest you add a warning when the plugin has elements for non-RBAC UI, but at the same time, it has no elements for RBAC Web UI.

Now there will be a message after running the airflow plugins command that will allow easier diagnosis of problems.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj merged commit e587320 into apache:master Jun 19, 2020
@mik-laj mik-laj deleted the warn-plugins branch June 19, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants