Skip to content

[Depends on #9457, #9456 & #9458] Select Checks to exclude instead of include for PyDocStyle #9459

Merged
kaxil merged 1 commit into
apache:masterfrom
astronomer:select-checks-to-ignore
Jun 21, 2020
Merged

[Depends on #9457, #9456 & #9458] Select Checks to exclude instead of include for PyDocStyle #9459
kaxil merged 1 commit into
apache:masterfrom
astronomer:select-checks-to-ignore

Conversation

@kaxil
Copy link
Copy Markdown
Member

@kaxil kaxil commented Jun 21, 2020

Depends on #9457, #9456 & #9458

Do the reverse of what we have in other Pull Request so it will be easy for us to in future to remove this "ignore checks" one by one


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg Bot added area:CLI area:dev-tools area:Scheduler including HA (high availability) scheduler k8s provider:amazon AWS/Amazon - related issues labels Jun 21, 2020
@kaxil kaxil requested a review from potiuk June 21, 2020 01:52
@kaxil kaxil force-pushed the select-checks-to-ignore branch from c93e871 to 6367e50 Compare June 21, 2020 01:53
@kaxil kaxil changed the title Select Checks to ignore instead of select for PyDocStyle [Depends on #9457, #9456 & #9458] Select Checks to ignore instead of select for PyDocStyle Jun 21, 2020
@kaxil kaxil changed the title [Depends on #9457, #9456 & #9458] Select Checks to ignore instead of select for PyDocStyle [Depends on #9457, #9456 & #9458] Select Checks to exclude instead of include for PyDocStyle Jun 21, 2020
@kaxil kaxil removed area:CLI area:Scheduler including HA (high availability) scheduler k8s provider:amazon AWS/Amazon - related issues labels Jun 21, 2020
Do the reverse of what we have in other Pull Request so it will be easy for us to in future to remove this "ignore checks" one by one
@kaxil kaxil force-pushed the select-checks-to-ignore branch from 6367e50 to 7e2040e Compare June 21, 2020 08:41
@kaxil kaxil requested a review from mik-laj June 21, 2020 08:43
Comment thread .pre-commit-config.yaml
name: Run pydocstyle
args:
- --select=D300,D301,D302,D101,D201,D206,D207,D208,D209,D211,D414
- --convention=pep257
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default for pydocstyle. Even if I remove this line, it won't make any difference

@kaxil kaxil merged commit 3981ed1 into apache:master Jun 21, 2020
@kaxil kaxil deleted the select-checks-to-ignore branch June 21, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants