Skip to content

Extract common date log logic in _run_raw_task#9512

Merged
turbaszek merged 2 commits into
apache:masterfrom
PolideaInternal:use-method-instead-if-else
Jun 26, 2020
Merged

Extract common date log logic in _run_raw_task#9512
turbaszek merged 2 commits into
apache:masterfrom
PolideaInternal:use-method-instead-if-else

Conversation

@turbaszek
Copy link
Copy Markdown
Member


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@turbaszek turbaszek requested review from feluelle and kaxil June 25, 2020 11:15

# If a timeout is specified for the task, make it fail
# if it goes beyond
result = None
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an unused argument, so I decided to remove it

Comment thread airflow/models/taskinstance.py Outdated
Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
@turbaszek turbaszek merged commit 529ba8f into apache:master Jun 26, 2020
@turbaszek turbaszek deleted the use-method-instead-if-else branch June 26, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants