Skip to content

Import ABC from collections.abc#9649

Merged
mik-laj merged 1 commit intoapache:masterfrom
tirkarthi:fix-collections
Jul 22, 2020
Merged

Import ABC from collections.abc#9649
mik-laj merged 1 commit intoapache:masterfrom
tirkarthi:fix-collections

Conversation

@tirkarthi
Copy link
Contributor

@tirkarthi tirkarthi commented Jul 4, 2020

collections.abc should be used while using ABC. collections is used which is incorrect. One of the other dependencies like logging import collections.abc and thus shadows this error. Relevant line :

elif isinstance(addresses, collections.abc.Iterable):


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj merged commit 46e34ab into apache:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments