Improve type annotations for ftp provider#9831
Closed
scrambldchannel wants to merge 23 commits intoapache:masterfrom
Closed
Improve type annotations for ftp provider#9831scrambldchannel wants to merge 23 commits intoapache:masterfrom
scrambldchannel wants to merge 23 commits intoapache:masterfrom
Conversation
scrambldchannel
changed the title
Contributor
Author
|
Hmmm, I have an issue here with test_renew_from_kt, will try to unpick it and review PR |
Member
|
Please ignore it. It's flaky build. |
…ache#9822) Until Airflow 1.10.10 the default run_as_user config (https://airflow.readthedocs.io/en/1.10.10/configurations-ref.html#run-as-user) which defaulted it to root user `0` (https://github.com/apache/airflow/blob/96697180d79bfc90f6964a8e99f9dd441789177c/airflow/contrib/executors/kubernetes_executor.py#L295-L301) In Airflow 1.10.11 we changed it to `50000`
Co-authored-by: Ashwin Shankar <ashankar@slack-corp.com>
* Change DAG.clear to take dag_run_state * fix lint * fix tests * assign var * extend original clause
…pache#8936) Documentation for S3FileTransformOperator states that users can skip transformation script if S3 Select experession is specified, but in this case the created file is always zero bytes long. This fix changes the behaviour, so in case of no transformation given, the source file (a result of S3Select) is uploaded.
…pache#9816) Rather than only allowing specific pre-determined config settings, this change allows the user to place _any_ config setting they like in the generated airflow.cfg, including overwriting the "generated defaults". This providers a nicer interface for the users of the chart (even if the could already set these via the env vars).
Co-authored-by: michalslowikowski00 <michal.slowikowski@polidea.com>
So that it can pull the specified image from a private registry.
Reviewed the scripts and removed some of the old unused ones.
* Add Snowflake support to SQL operator and sensor * Add test for conn_type to valid hook mapping * Improve code quality for conn type mapping test
Co-authored-by: Johan Eklund <jeklund@zynga.com> Co-authored-by: Tomek Urbaszek <turbaszek@gmail.com>
* we come back to idea of having one CI workflow * cancel and openapi are incorporated into that CI workflow * cancel retrieves workflow id automatically (works for forks) * static checks are now merged into one job * less dependencies between jobs so that waiting is minimised * better name for check if tests should be run * separated out script for tests should be run check
Contributor
Author
|
Closed this and will clean up and re-open |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved type annotations for ftp provider as per #9708
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.