Add "all" to list of valid breeze integrations#9858
Closed
scrambldchannel wants to merge 5 commits intoapache:masterfrom
Closed
Add "all" to list of valid breeze integrations#9858scrambldchannel wants to merge 5 commits intoapache:masterfrom
scrambldchannel wants to merge 5 commits intoapache:masterfrom
Conversation
Member
|
You will also need to add "all" to pre_commit_check_integrations.sh and run |
Member
|
Something like that: |
Contributor
Author
Ah ok, missed that. I'll take a look soon and update the PR. Thanks! |
Contributor
Author
|
OK, I realised I'd nuked my repo and hadn't re-applied the pre-commit hooks, my bad. I also merged rather than rebased. I was going to close this PR and open a newer one to clean it all up but then ran into a weird error with the check_integrations pre commit hook which failed with. Maybe _common_values.sh is no longer being read before the test is run? I am a novice when it comes to the pre commit framework but am trying to muddle through it, will raise an issue if I can determine it properly. |
This was referenced Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've tried to address #9857. This change allows use of the "all" option.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.