Skip to content

Comments

Add "all" to list of valid breeze integrations#9858

Closed
scrambldchannel wants to merge 5 commits intoapache:masterfrom
scrambldchannel:breeze_integrations
Closed

Add "all" to list of valid breeze integrations#9858
scrambldchannel wants to merge 5 commits intoapache:masterfrom
scrambldchannel:breeze_integrations

Conversation

@scrambldchannel
Copy link
Contributor

Hi, I've tried to address #9857. This change allows use of the "all" option.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member

potiuk commented Jul 16, 2020

You will also need to add "all" to pre_commit_check_integrations.sh and run pre-commit run update-breeze-file to update the docs.

@potiuk
Copy link
Member

potiuk commented Jul 16, 2020

Something like that:

if [[ "${AVAILABLE_INTEGRATIONS} all" != "${_BREEZE_ALLOWED_INTEGRATIONS}" ]]; then

@scrambldchannel
Copy link
Contributor Author

Something like that:

if [[ "${AVAILABLE_INTEGRATIONS} all" != "${_BREEZE_ALLOWED_INTEGRATIONS}" ]]; then

Ah ok, missed that. I'll take a look soon and update the PR. Thanks!

@scrambldchannel
Copy link
Contributor Author

OK, I realised I'd nuked my repo and hadn't re-applied the pre-commit hooks, my bad. I also merged rather than rebased. I was going to close this PR and open a newer one to clean it all up but then ran into a weird error with the check_integrations pre commit hook which failed with.

./scripts/ci/pre_commit/pre_commit_check_integrations.sh: line 26: AVAILABLE_INTEGRATIONS: unbound variable

Maybe _common_values.sh is no longer being read before the test is run? I am a novice when it comes to the pre commit framework but am trying to muddle through it, will raise an issue if I can determine it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants