Breeze / KinD - support earlier k8s versions, fix recreate and kubectl versioning#9905
Merged
potiuk merged 6 commits intoapache:masterfrom Jul 22, 2020
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
potiuk
requested changes
Jul 21, 2020
Contributor
Author
|
Hi @potiuk, added the changes yesterday, let me know if there's anything else missing |
Member
|
Fantastic! Thanks @bbenzikry |
potiuk
approved these changes
Jul 22, 2020
|
Awesome work, congrats on your first merged pull request! |
Member
|
cc: @kaxil @dimberman - we have now three versions of Kubernetes tested. I am cherry-picking all the changes to 1.10 now. |
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…l versioning (apache#9905) (cherry picked from commit 24a951e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers several small issues;
which is an issue for many projects in 1.18 due to Extended CRD Validation kubernetes/kubernetes#88076
A few reference issues:
CRDs don't pass validation on k8s 1.18 kubeflow/spark-operator#921
CustomResourceDefinition is invalid at kubernetes 1.18 operator-framework/operator-sdk#3235
Default value not allowed for in x-kubernetes-list-map-keys kubernetes-sigs/controller-tools#444
I've added the latest versions from kind ( v1.17.5, v1.16.9 ) and updated the default version to v1.18.6
breeze kind-cluster recreatedid not seem to work even though it's mentioned in the breeze docs.Currently throws:
breeze kind-cluster deployhad a typo in perform_kind_cluster_operationkind-cluster kubectl version ignored KUBERNETES_VERSION ( typo )
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.