Add type annotations to providers/vertica#9936
Merged
mik-laj merged 1 commit intoapache:masterfrom Jul 23, 2020
Merged
Conversation
cjsekl
commented
Jul 22, 2020
| Return verticaql connection object | ||
| """ | ||
| conn = self.get_connection(self.vertica_conn_id) # pylint: disable=no-member | ||
| conn = self.get_connection(self.vertica_conn_id) # type: ignore # pylint: disable=no-member |
Contributor
Author
There was a problem hiding this comment.
This is ignored by pylint and mypy because VerticaHook.vertica_conn_id overrides DbApiHook.conn_name_attr.
Is there a better way to handle this than ignoring?
mik-laj
approved these changes
Jul 23, 2020
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #9708
Adding type annotations to
providers/vertica.