Skip to content

Revert "Bump mysqlclient to 2.0.1 (#9987)"#9997

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:revert-mysql-upgrade
Jul 25, 2020
Merged

Revert "Bump mysqlclient to 2.0.1 (#9987)"#9997
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:revert-mysql-upgrade

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 25, 2020

This reverts commit c438812.

Seems that mysql upgrade caused a problem with missing _mysql_exceptions. Let's revert before we investigate and fix.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested review from kaxil, mik-laj and turbaszek July 25, 2020 10:02
@potiuk potiuk merged commit 2f73974 into apache:master Jul 25, 2020
@potiuk potiuk deleted the revert-mysql-upgrade branch July 25, 2020 10:19
@potiuk
Copy link
Member Author

potiuk commented Jul 25, 2020

Explanation: the problem is @kaxil that in the regular PR runs there is no "eager upgrade" performed, so just changing the upper bound will not make the dependency to be upgraded to latest version in the PR.

This is in order to make sure we are not hit in PRs by the external dependency upgrade problems we used to have. It's only the master merges that perform "eager upgrade" and run tests on the latest versions of requirements - this way we have a chance to react before all PRs are affected. So the "early warning" worked in this case in fact (other's PR would be unaffected as they would still be using the "constrained" version of mysql which is still 1.3.14 - it's only master build that was affected). Also since the master build failed- the constraints would not be upgraded, which is exactly what is expected :).

In order to actually test the latest version locally you need to enter breeze and run:

pip install --upgrade mysqlclient and run tests after that or simply push the change you want to test to your local fork as master.

@kaxil
Copy link
Member

kaxil commented Jul 25, 2020

Explanation: the problem is @kaxil that in the regular PR runs there is no "eager upgrade" performed, so just changing the upper bound will not make the dependency to be upgraded to latest version in the PR.

This is in order to make sure we are not hit in PRs by the external dependency upgrade problems we used to have. It's only the master merges that perform "eager upgrade" and run tests on the latest versions of requirements - this way we have a chance to react before all PRs are affected. So the "early warning" worked in this case in fact (other's PR would be unaffected as they would still be using the "constrained" version of mysql which is still 1.3.14 - it's only master build that was affected). Also since the master build failed- the constraints would not be upgraded, which is exactly what is expected :).

In order to actually test the latest version locally you need to enter breeze and run:

pip install --upgrade mysqlclient and run tests after that or simply push the change you want to test to your local fork as master.

Got it, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants