Skip to content

[AMBARI-24111] Enable configs originating from mpack advisor to be added#1548

Merged
jgolieb merged 2 commits intoapache:branch-feature-AMBARI-14714-mpack-advisorfrom
jgolieb:AMBARI-24111_add-configs
Jun 15, 2018
Merged

[AMBARI-24111] Enable configs originating from mpack advisor to be added#1548
jgolieb merged 2 commits intoapache:branch-feature-AMBARI-14714-mpack-advisorfrom
jgolieb:AMBARI-24111_add-configs

Conversation

@jgolieb
Copy link
Copy Markdown

@jgolieb jgolieb commented Jun 15, 2018

What changes were proposed in this pull request?

Populated configTypes property so that configs coming from mpack advisory can get added to the overall list of configs in the UI.

How was this patch tested?

All unit tests passing.

@jgolieb jgolieb self-assigned this Jun 15, 2018
@jgolieb jgolieb requested review from atkach, ishanbha and jayush June 15, 2018 13:54
@asfgit
Copy link
Copy Markdown

asfgit commented Jun 15, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2725/
Test FAILed.
Test FAILured.

@jgolieb jgolieb merged commit c0af6ea into apache:branch-feature-AMBARI-14714-mpack-advisor Jun 15, 2018
@jgolieb jgolieb deleted the AMBARI-24111_add-configs branch June 15, 2018 17:21
jgolieb pushed a commit that referenced this pull request Jun 22, 2018
* AMBARI-14714. Fix some unit tests

* AMBARI-14714. Fix ServiceResourceProviderTest

* Clear clusterData when user is not logged in.

* Remove references to deleted unit test files and fix broken tests.

* AMBARI-23746. Cannot create same named service in different service groups in same request

* AMBARI-23746. Cannot create same named component in different service groups in same request

* [AMBARI-23969] UI should load stack services from multiple mpacks. (#1403)

* [AMBARI-23969] UI should load stack services from multiple mpacks.

* Removed stack version number

* AMBARI-23972. Update code for : (1). 'mpack-recommendations' directory creation and (2). putting 'mpack_advisor_wrapper.py' in '/var/lib/ambari-server/resources/scripts/' folder.

* AMBARI-22875. Service group name mismatch

* AMBARI-23746. Cannot query services with same name

* AMBARI-23746. Use List for componentID duplicate check

* AMBARI-23987. Set 'skip.service.checks' = true during deploy.

* AMBARI-23999 Remove hardcoded logic in UI to create HDPCORE service group and create multiple service groups

* [AMBARI-23993] Mpack Instance Manager should create pid dir and log dir for each instance (#1424)

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993-2: Mpack Instance Manager should create pid dir and log dir for each instance: add get_log_dir and get_run_dir to import

* Merge from main feature branch (#1481)

* Remove references to deleted unit test files and fix broken tests.

* [AMBARI-23969] UI should load stack services from multiple mpacks. (#1403)

* [AMBARI-23969] UI should load stack services from multiple mpacks.

* Removed stack version number

* AMBARI-23972. Update code for : (1). 'mpack-recommendations' directory creation and (2). putting 'mpack_advisor_wrapper.py' in '/var/lib/ambari-server/resources/scripts/' folder.

* AMBARI-14714. Fix some unit tests

* AMBARI-14714. Fix ServiceResourceProviderTest

* AMBARI-23746. Cannot create same named service in different service groups in same request

* AMBARI-23746. Cannot create same named component in different service groups in same request

* AMBARI-22875. Service group name mismatch

* AMBARI-23746. Cannot query services with same name

* AMBARI-23746. Use List for componentID duplicate check

* AMBARI-23987. Set 'skip.service.checks' = true during deploy.

* Clear clusterData when user is not logged in.

* [AMBARI-23993] Mpack Instance Manager should create pid dir and log dir for each instance (#1424)

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993-2: Mpack Instance Manager should create pid dir and log dir for each instance: add get_log_dir and get_run_dir to import

* AMBARI-23999 Remove hardcoded logic in UI to create HDPCORE service group and create multiple service groups

* AMBARI-24011: Add workaround to hide client modules in the dashboard (jluniya) (#1443)

Change-Id: Ie69b4e0ca654d59952807694cf2f3f24d6b74c0d

* BUG-104321: Python Mpack Advisor should return MpackInstance block during Host Component Layout Recommendation

* AMBARI-24025 Display Mpack Info on Service Summary Page

* AMBARI-24025 Display Mpack Info on Service Summary Page

* AMBARI-23986. Host components API call doesn't return all host components (#1450)

* AMBARI-24030. Fixes the following : 1. Reading the Node Manager Host (nmHost) correctly. 2. Comments the incorrectly implemented fn : isServiceDeployed().

* AMBARI-24025 Display Mpack Info on Service Summary Page

* [AMBARI-24039] Quicklinks for HBASE are not displayed.

* [AMBARI-24033] Use servicegroup api instead of service to show installed services in the UI.

* AMBARI-14714. Fix some unit tests (#1464)

* Merge from main feature branch. (#1485)

* Remove references to deleted unit test files and fix broken tests.

* [AMBARI-23969] UI should load stack services from multiple mpacks. (#1403)

* [AMBARI-23969] UI should load stack services from multiple mpacks.

* Removed stack version number

* AMBARI-23972. Update code for : (1). 'mpack-recommendations' directory creation and (2). putting 'mpack_advisor_wrapper.py' in '/var/lib/ambari-server/resources/scripts/' folder.

* AMBARI-14714. Fix some unit tests

* AMBARI-14714. Fix ServiceResourceProviderTest

* AMBARI-23746. Cannot create same named service in different service groups in same request

* AMBARI-23746. Cannot create same named component in different service groups in same request

* AMBARI-22875. Service group name mismatch

* AMBARI-23746. Cannot query services with same name

* AMBARI-23746. Use List for componentID duplicate check

* AMBARI-23987. Set 'skip.service.checks' = true during deploy.

* Clear clusterData when user is not logged in.

* [AMBARI-23993] Mpack Instance Manager should create pid dir and log dir for each instance (#1424)

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993-2: Mpack Instance Manager should create pid dir and log dir for each instance: add get_log_dir and get_run_dir to import

* AMBARI-23999 Remove hardcoded logic in UI to create HDPCORE service group and create multiple service groups

* AMBARI-24011: Add workaround to hide client modules in the dashboard (jluniya) (#1443)

Change-Id: Ie69b4e0ca654d59952807694cf2f3f24d6b74c0d

* BUG-104321: Python Mpack Advisor should return MpackInstance block during Host Component Layout Recommendation

* AMBARI-24025 Display Mpack Info on Service Summary Page

* AMBARI-24025 Display Mpack Info on Service Summary Page

* AMBARI-23986. Host components API call doesn't return all host components (#1450)

* AMBARI-24030. Fixes the following : 1. Reading the Node Manager Host (nmHost) correctly. 2. Comments the incorrectly implemented fn : isServiceDeployed().

* AMBARI-24025 Display Mpack Info on Service Summary Page

* [AMBARI-24039] Quicklinks for HBASE are not displayed.

* [AMBARI-24033] Use servicegroup api instead of service to show installed services in the UI.

* AMBARI-14714. Fix some unit tests (#1464)

* AMBARI-24046. Fix the incorrect string from config_name to config-name in mpack_advisor.py (#1480)

* Revert previous commit (#1486)

* Remove references to deleted unit test files and fix broken tests.

* [AMBARI-23969] UI should load stack services from multiple mpacks. (#1403)

* [AMBARI-23969] UI should load stack services from multiple mpacks.

* Removed stack version number

* AMBARI-23972. Update code for : (1). 'mpack-recommendations' directory creation and (2). putting 'mpack_advisor_wrapper.py' in '/var/lib/ambari-server/resources/scripts/' folder.

* AMBARI-14714. Fix some unit tests

* AMBARI-14714. Fix ServiceResourceProviderTest

* AMBARI-23746. Cannot create same named service in different service groups in same request

* AMBARI-23746. Cannot create same named component in different service groups in same request

* AMBARI-22875. Service group name mismatch

* AMBARI-23746. Cannot query services with same name

* AMBARI-23746. Use List for componentID duplicate check

* AMBARI-23987. Set 'skip.service.checks' = true during deploy.

* Clear clusterData when user is not logged in.

* [AMBARI-23993] Mpack Instance Manager should create pid dir and log dir for each instance (#1424)

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993-2: Mpack Instance Manager should create pid dir and log dir for each instance: add get_log_dir and get_run_dir to import

* AMBARI-23999 Remove hardcoded logic in UI to create HDPCORE service group and create multiple service groups

* AMBARI-24011: Add workaround to hide client modules in the dashboard (jluniya) (#1443)

Change-Id: Ie69b4e0ca654d59952807694cf2f3f24d6b74c0d

* BUG-104321: Python Mpack Advisor should return MpackInstance block during Host Component Layout Recommendation

* AMBARI-24025 Display Mpack Info on Service Summary Page

* AMBARI-24025 Display Mpack Info on Service Summary Page

* AMBARI-23986. Host components API call doesn't return all host components (#1450)

* AMBARI-24030. Fixes the following : 1. Reading the Node Manager Host (nmHost) correctly. 2. Comments the incorrectly implemented fn : isServiceDeployed().

* AMBARI-24025 Display Mpack Info on Service Summary Page

* [AMBARI-24039] Quicklinks for HBASE are not displayed.

* [AMBARI-24033] Use servicegroup api instead of service to show installed services in the UI.

* AMBARI-14714. Fix some unit tests (#1464)

* AMBARI-24046. Fix the incorrect string from config_name to config-name in mpack_advisor.py (#1480)

* [AMBARI-23643] Mpack Advisor integration in Install wizard.

* Revert "[AMBARI-23643] Mpack Advisor integration in Install wizard."

This reverts commit 01efc2c.

* [AMBARI-23643] Mpack Advisor integration in Install Wizard (#1487)

* Remove references to deleted unit test files and fix broken tests.

* [AMBARI-23969] UI should load stack services from multiple mpacks. (#1403)

* [AMBARI-23969] UI should load stack services from multiple mpacks.

* Removed stack version number

* AMBARI-23972. Update code for : (1). 'mpack-recommendations' directory creation and (2). putting 'mpack_advisor_wrapper.py' in '/var/lib/ambari-server/resources/scripts/' folder.

* AMBARI-14714. Fix some unit tests

* AMBARI-14714. Fix ServiceResourceProviderTest

* AMBARI-23746. Cannot create same named service in different service groups in same request

* AMBARI-23746. Cannot create same named component in different service groups in same request

* AMBARI-22875. Service group name mismatch

* AMBARI-23746. Cannot query services with same name

* AMBARI-23746. Use List for componentID duplicate check

* AMBARI-23987. Set 'skip.service.checks' = true during deploy.

* Clear clusterData when user is not logged in.

* [AMBARI-23993] Mpack Instance Manager should create pid dir and log dir for each instance (#1424)

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993: Mpack Instance Manager should create pid dir and log dir for each instance

* AMBARI-23993-2: Mpack Instance Manager should create pid dir and log dir for each instance: add get_log_dir and get_run_dir to import

* AMBARI-23999 Remove hardcoded logic in UI to create HDPCORE service group and create multiple service groups

* AMBARI-24011: Add workaround to hide client modules in the dashboard (jluniya) (#1443)

Change-Id: Ie69b4e0ca654d59952807694cf2f3f24d6b74c0d

* BUG-104321: Python Mpack Advisor should return MpackInstance block during Host Component Layout Recommendation

* AMBARI-24025 Display Mpack Info on Service Summary Page

* AMBARI-24025 Display Mpack Info on Service Summary Page

* AMBARI-23986. Host components API call doesn't return all host components (#1450)

* AMBARI-24030. Fixes the following : 1. Reading the Node Manager Host (nmHost) correctly. 2. Comments the incorrectly implemented fn : isServiceDeployed().

* AMBARI-24025 Display Mpack Info on Service Summary Page

* [AMBARI-24039] Quicklinks for HBASE are not displayed.

* [AMBARI-24033] Use servicegroup api instead of service to show installed services in the UI.

* AMBARI-14714. Fix some unit tests (#1464)

* AMBARI-24046. Fix the incorrect string from config_name to config-name in mpack_advisor.py (#1480)

* [AMBARI-23643] Mpack Advisor integration in Install wizard.

* [AMBARI-24053] Do not move service-specific configs to Misc section

* [AMBARI-24053] Fix bug in previous commit to this issue.

* [AMBARI-24111] Enable configs originating from mpack advisor to be added (#1548)

* [AMBARI-24111] Enable configs originating from mpack advisor to be added.

* Fixed unit test.

* [AMBARI-24083] Enable same service to be installed from multiple mpacks (#1538)

* [AMBARI-24083] Allow clients from multiple mpacks to be installed

* Unit test fixes.

* Unit test added

* [AMBARI-24115] Install all services and start all services with a single request each

* [AMBARI-24137] Fixed mpack display on service summary view.

* [AMBARI-24095] Fixed usages of App.StackService.find(serviceName) since serviceName is no longer used as the value of the StackService model id. (#1581)

* [AMBARI-24095] Fixed usages of App.StackService.find(serviceName) since serviceName is no longer used as the value of the StackService model id.

* Fixed installation issue.

* Fixed a couple instances that were hard-coded.

* Fixed unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants