Skip to content

[AMBARI-25398] Textareas in configuration page can be resized beyond its container border limit#3105

Merged
hapylestat merged 2 commits intoapache:branch-2.7from
paul8263:AMBARI-25398-branch-2.7
Oct 5, 2020
Merged

[AMBARI-25398] Textareas in configuration page can be resized beyond its container border limit#3105
hapylestat merged 2 commits intoapache:branch-2.7from
paul8263:AMBARI-25398-branch-2.7

Conversation

@paul8263
Copy link
Copy Markdown

[AMBARI-25398] Textareas in configuration page can be resized beyond its container border limit

What changes were proposed in this pull request?

Changed the CSS for textareas with the class of "ember-text-area" located inside "service-config-section" div. Added max-width and min-width restriction.

How was this patch tested?

Recompiled ambari project and installed.

@asf-ci
Copy link
Copy Markdown

asf-ci commented Oct 23, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5495/
Test FAILed.
Test FAILured.

@paul8263
Copy link
Copy Markdown
Author

I got confused that with some CSS code changes finally it ended with a Ambari Server Test Failure, as shown below:

2833777 [ERROR] testInMemoryCredentialStoreService_CredentialExpired(org.apache.ambari.server.security.encryption.CredentialStoreTest)  Time elapsed: 0.776 s  <<< ERROR!
java.lang.NullPointerException
	at org.apache.ambari.server.security.encryption.CredentialStoreTest.getExpiredCredentialTest(CredentialStoreTest.java:169)
	at org.apache.ambari.server.security.encryption.CredentialStoreTest.testInMemoryCredentialStoreService_CredentialExpired(CredentialStoreTest.java:90)
3198411 [ERROR] Errors: 
3198411 [ERROR]   CredentialStoreTest.testInMemoryCredentialStoreService_CredentialExpired:90->getExpiredCredentialTest:169 NullPointer
3198412 [INFO] 
3198412 [ERROR] Tests run: 5261, Failures: 0, Errors: 1, Skipped: 69

The branch I committed to is branch-2.7

How could I run the build again or do some additional check?

@paul8263
Copy link
Copy Markdown
Author

retest this please

@asf-ci
Copy link
Copy Markdown

asf-ci commented Oct 23, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5496/
Test FAILed.
Test FAILured.

@paul8263
Copy link
Copy Markdown
Author

I did the build again but as a result I got a different test failure (Ambari Server):

1152574 [ERROR] testOPFailedEventForAbortedTask(org.apache.ambari.server.agent.TestHeartbeatHandler)  Time elapsed: 1.242 s  <<< ERROR!
java.util.ConcurrentModificationException
	at org.apache.ambari.server.agent.TestHeartbeatHandler.testOPFailedEventForAbortedTask(TestHeartbeatHandler.java:857)

Conversely, in my first build run, TestHeartbeatHandler showed no errors:

2130336 [WARNING] Tests run: 24, Failures: 0, Errors: 0, Skipped: 9, Time elapsed: 79.89 s - in org.apache.ambari.server.agent.TestHeartbeatHandler

@paul8263
Copy link
Copy Markdown
Author

retest this please

@asf-ci
Copy link
Copy Markdown

asf-ci commented Oct 23, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5498/
Test FAILed.
Test FAILured.

@asf-ci
Copy link
Copy Markdown

asf-ci commented Oct 24, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5499/
Test FAILed.
Test FAILured.

@paul8263
Copy link
Copy Markdown
Author

retest this please

@asf-ci
Copy link
Copy Markdown

asf-ci commented Oct 24, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5500/
Test FAILed.
Test FAILured.

@hapylestat hapylestat requested a review from atkach October 5, 2020 13:42
@hapylestat hapylestat self-assigned this Oct 5, 2020
@hapylestat hapylestat added the web client Ambari WebUI Client label Oct 5, 2020
Copy link
Copy Markdown
Contributor

@hapylestat hapylestat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web client Ambari WebUI Client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants