Skip to content

Conversation

@echohlne
Copy link

@echohlne echohlne commented Oct 24, 2020

What changes were proposed in this pull request?

The name of the metrics data exported in Ambari-web is always data.json/csv, and the exported file usually must be renamed to distinguish which metric the data belongs to

so we try to custom the exported metric data file name, make the export function more friendly.

there are some changes in the file name of the exported metrics for example:

Entry metric name Old Exported File Name NewExported Filname
Dashboard Memory Usage data.csv/json memory_usage.csv/json
Services/HDFS NameNode GC Count data.csv/json hdfs_namenode_gc_count.csv/json
Services/HBase Read Latency data.csv/json habse_read_latency.csv.json

How was this patch tested?

checked all the metrics support exported, both shows ok, part of manual test result shows below,

微信截图_20201025022602

@echohlne echohlne changed the title Custom metrics download file name [AMBARI-25573] Ambari Metrics save as JSON/CSV use custom fileName instead of default name. Oct 24, 2020
@payert
Copy link

payert commented Oct 27, 2020

@pidhaietsdp Could you take a quick look to this PR? To me it makes sense. Thanks!

@payert payert self-requested a review October 27, 2020 12:15
@echohlne
Copy link
Author

@payert @pidhaietsdp done.

Copy link

@payert payert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@payert payert merged commit 0475c20 into apache:branch-2.7 Oct 28, 2020
hapylestat added a commit that referenced this pull request Nov 2, 2020
…ame instead of default name. (#3247)"

This reverts commit 0475c20.
hapylestat added a commit that referenced this pull request Nov 2, 2020
…ame instead of default name. (#3247)" (#3253)

This reverts commit 0475c20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants