-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[AMBARI-25573] Ambari Metrics save as JSON/CSV use custom fileName instead of default name. #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
payert
merged 14 commits into
apache:branch-2.7
from
echohlne:custom_metrics_download_file_name
Oct 28, 2020
Merged
[AMBARI-25573] Ambari Metrics save as JSON/CSV use custom fileName instead of default name. #3247
payert
merged 14 commits into
apache:branch-2.7
from
echohlne:custom_metrics_download_file_name
Oct 28, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pidhaietsdp Could you take a quick look to this PR? To me it makes sense. Thanks! |
pidhaietsdp
reviewed
Oct 27, 2020
Author
|
@payert @pidhaietsdp done. |
payert
approved these changes
Oct 28, 2020
payert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The name of the metrics data exported in Ambari-web is always data.json/csv, and the exported file usually must be renamed to distinguish which metric the data belongs to
so we try to custom the exported metric data file name, make the export function more friendly.
there are some changes in the file name of the exported metrics for example:
How was this patch tested?
checked all the metrics support exported, both shows ok, part of manual test result shows below,