[AMBARI-25422] the interface to get serviceInfo is too slow#3285
Open
eubnara wants to merge 1 commit intoapache:branch-2.7from
Open
[AMBARI-25422] the interface to get serviceInfo is too slow#3285eubnara wants to merge 1 commit intoapache:branch-2.7from
eubnara wants to merge 1 commit intoapache:branch-2.7from
Conversation
Contributor
Author
|
build failure is caused by broken link to ambari metrics package.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
There are unnecessary iteration on List Services API.
There is no need to iterate all hosts to get effective config properties.
As Ambari cluster grows with mant hosts, Ambari UI first load is getting slower.
(As mentioned in https://issues.apache.org/jira/browse/AMBARI-25422 caused by api call :
http://{ip}:{port}/api/v1/clusters/{cluster}/services?fields=ServiceInfo/state,ServiceInfo/maintenance_state,ServiceInfo/desired_repository_version_id,components/ServiceComponentInfo/component_name&minimal_response=true&_=1572316944944)How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
I tested it with test ambari cluster in our company.
Please review Ambari Contributing Guide before opening a pull request.