Skip to content

AMBARI-25636 FindBugs: Comparison of String parameter using == or !=#3299

Merged
hapylestat merged 3 commits intoapache:branch-2.7from
payert:AMBARI-25636-branch-2.7
Mar 25, 2021
Merged

AMBARI-25636 FindBugs: Comparison of String parameter using == or !=#3299
hapylestat merged 3 commits intoapache:branch-2.7from
payert:AMBARI-25636-branch-2.7

Conversation

@payert
Copy link

@payert payert commented Mar 19, 2021

What changes were proposed in this pull request?

Refactored setStatus() of HostImpl class where String comparison was done by == operator.

How was this patch tested?

Unit tests has been added

Tamas Payer added 3 commits March 17, 2021 14:50
Change-Id: Ibadd3a94d1fc0035e6afa17efdcbdf56a98d565a
Change-Id: Idb5d032460ce67c351aafc28dfe9e8146a4befc5
Change-Id: I7fa4d936359502d27caf3381912ad696f829b96a
@payert payert added cleanup server Ambari server labels Mar 19, 2021
@payert payert self-assigned this Mar 19, 2021
@payert payert requested a review from hapylestat March 20, 2021 10:36
Copy link
Contributor

@hapylestat hapylestat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm+1

@hapylestat hapylestat merged commit 66bb30c into apache:branch-2.7 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup server Ambari server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants