[AMBARI-25671] Moved cache deletion at the end in delete flow#3306
Closed
shubhamod wants to merge 1 commit intoapache:trunkfrom
Closed
[AMBARI-25671] Moved cache deletion at the end in delete flow#3306shubhamod wants to merge 1 commit intoapache:trunkfrom
shubhamod wants to merge 1 commit intoapache:trunkfrom
Conversation
shubhamod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
According to current delete flow, we are deleting the cache data first and then deleting data from db. But if due to anycase like Rollback exceptions , we delete the data from cache but data in DB is rollbacked. Due to this when again we try to delete the host data, it throws hostNotFound since it takes this check from cache given below.
Set clusters = getHostClustersMap().get(hostname);
if (clusters == null) {
throw new HostNotFoundException(hostname);
}
if (!getHostsByName().containsKey(hostname)) { throw new HostNotFoundException("Could not find host " + hostname); }
So even though data is not actually deleted from DB , we still wont delete from DB because of this. The current way is to restart ambari server which fills up the cache again and then it works fine, but until that, we wont be able to delete anything for this hostName.
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
Please review Ambari Contributing Guide before opening a pull request.