AMBARI-25693 Ambari Admin View failed to build due to PhantomJS#3318
Merged
hapylestat merged 3 commits intoapache:branch-2.7from Nov 2, 2021
Merged
AMBARI-25693 Ambari Admin View failed to build due to PhantomJS#3318hapylestat merged 3 commits intoapache:branch-2.7from
hapylestat merged 3 commits intoapache:branch-2.7from
Conversation
switch to using yarn instead of npm similar to ambari-web.
Contributor
Author
|
@hapylestat, @payert could you please review this PR? |
Contributor
Author
|
retest this please |
Contributor
Author
|
recheck this please |
1 similar comment
|
recheck this please |
|
recheck |
|
retest |
Contributor
Author
|
@hapylestat I tried to restart the CI job but failed. Could you please help with this? |
Change-Id: I13778120df5e86a8804bcbc9743fe09547321cff
Change-Id: Id1f714cab62015639c5b703102ac619d51da3603
Contributor
Author
|
I successfully executed the command that failed during the PR check. (Apache Maven 3.8.3) The build issues in the ambari-infra and ambari-logsearch are due to the latest maven, as it blocks the external http repositories since the 3.8.1. I don't think fixing it is part of this PR as it works with previous maven releases (Apache Maven 3.6.3). |
hapylestat
approved these changes
Nov 2, 2021
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Switched to using yarn instead of npm in the ambari-admin-view project, similar to ambari-web.
How was this patch tested?
The patch was tested manually. The ambari-admin-view project was successfully built.