Skip to content

AMBARI-25693 Ambari Admin View failed to build due to PhantomJS#3318

Merged
hapylestat merged 3 commits intoapache:branch-2.7from
sziszo:AMBARI-25693-branch-2.7
Nov 2, 2021
Merged

AMBARI-25693 Ambari Admin View failed to build due to PhantomJS#3318
hapylestat merged 3 commits intoapache:branch-2.7from
sziszo:AMBARI-25693-branch-2.7

Conversation

@sziszo
Copy link
Contributor

@sziszo sziszo commented Oct 26, 2021

What changes were proposed in this pull request?

Switched to using yarn instead of npm in the ambari-admin-view project, similar to ambari-web.

How was this patch tested?

The patch was tested manually. The ambari-admin-view project was successfully built.

switch to using yarn instead of npm similar to ambari-web.
@sziszo
Copy link
Contributor Author

sziszo commented Oct 26, 2021

@hapylestat, @payert could you please review this PR?

@sziszo sziszo changed the title Ambari 25693 Ambari Admin View failed to build due to PhantomJS AMBARI-25693 Ambari Admin View failed to build due to PhantomJS Oct 26, 2021
@sziszo
Copy link
Contributor Author

sziszo commented Oct 26, 2021

retest this please

@payert payert self-requested a review October 26, 2021 14:07
Copy link

@payert payert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sziszo
Copy link
Contributor Author

sziszo commented Oct 27, 2021

recheck this please

1 similar comment
@payert
Copy link

payert commented Oct 27, 2021

recheck this please

@payert
Copy link

payert commented Oct 27, 2021

recheck

@payert
Copy link

payert commented Oct 27, 2021

retest

@sziszo
Copy link
Contributor Author

sziszo commented Oct 27, 2021

@hapylestat I tried to restart the CI job but failed. Could you please help with this?

Change-Id: I13778120df5e86a8804bcbc9743fe09547321cff
Change-Id: Id1f714cab62015639c5b703102ac619d51da3603
@sziszo
Copy link
Contributor Author

sziszo commented Nov 2, 2021

I successfully executed the command that failed during the PR check. (Apache Maven 3.8.3)

$ mvn -T 2C -am test -pl ambari-web,ambari-admin -Dmaven.artifact.threads=10 -Drat.skip
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
[INFO] Scanning for projects...

...

[INFO]
[INFO] --- apache-rat-plugin:0.12:check (default) @ ambari-web ---
[INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Ambari Main 2.7.5.0.0:
[INFO]
[INFO] Ambari Main ........................................ SUCCESS [  0.505 s]
[INFO] Apache Ambari Project POM .......................... SUCCESS [  0.006 s]
[INFO] Ambari Web ......................................... SUCCESS [01:24 min]
[INFO] Ambari Admin View .................................. SUCCESS [ 22.725 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:28 min (Wall Clock)
[INFO] Finished at: 2021-11-02T10:11:10+01:00
[INFO] ------------------------------------------------------------------------

The build issues in the ambari-infra and ambari-logsearch are due to the latest maven, as it blocks the external http repositories since the 3.8.1. I don't think fixing it is part of this PR as it works with previous maven releases (Apache Maven 3.6.3).

@hapylestat
Copy link
Contributor

LGTM

@hapylestat hapylestat merged commit 20298d4 into apache:branch-2.7 Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants