Skip to content

Conversation

@smallyao
Copy link
Contributor

@smallyao smallyao commented Oct 9, 2022

What changes were proposed in this pull request?

If hosts number is less than 4, namenode federation wizard shoud not be allowed.

image
image

How was this patch tested?

Tested in local vm cluster,
After applying this patch, if hosts number is less than 4, the button Add New HDFS Namespace is gray and cann't enable nn federation .

1e4117c6b1ef9064444186498628c16

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@smallyao smallyao changed the title Web Should Not Support Enabling NameNode Federation If Hosts Numbers Less than 4 AMBARI-25753:Web Should Not Support Enabling NameNode Federation If Hosts Numbers Less than 4 Oct 9, 2022
@smallyao smallyao changed the title AMBARI-25753:Web Should Not Support Enabling NameNode Federation If Hosts Numbers Less than 4 AMBARI-25753:Web Should Not Support Enabling NameNode Federation If Hosts Number Less than 4 Oct 9, 2022
@kevinw66
Copy link
Contributor

Considering that when HA is enabled, we need at least 4 hosts to add new namenode and it's standby namenode. It's reasonable we disable the button when host number is less than 4.

Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @smallyao

@kevinw66 kevinw66 merged commit 288e119 into apache:trunk Oct 10, 2022
@smallyao smallyao deleted the ambari-25753 branch November 9, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants