AMBARI-26591: Pin form2js to v2.0 to fix WF Manager build failure caused by wildcard dependency resolution#4116
Open
dilrajsourabh wants to merge 1 commit intoapache:trunkfrom
Open
Conversation
…sed by wildcard dependency resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR pins the form2js dependency to a fixed version (maxatwork/form2js#v2.0) in contrib/views/wfmanager/src/main/resources/ui/bower.json.
Previously, "form2js": "*" resolved to the latest tag, which recently changed and no longer contains the expected src/form2js.js structure required by Ambari.
Pinning the version restores the expected folder layout and prevents the ENOENT build failure.
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.