Skip to content

chore: remove copyright.txt#2722

Closed
caicancai wants to merge 1 commit into
apache:masterfrom
caicancai:remove
Closed

chore: remove copyright.txt#2722
caicancai wants to merge 1 commit into
apache:masterfrom
caicancai:remove

Conversation

@caicancai

@caicancai caicancai commented Apr 8, 2024

Copy link
Copy Markdown
Member

Why are the changes needed?

remove copyright.txt

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@caicancai

Copy link
Copy Markdown
Member Author

@zhoujinsong I think the copyright can be deleted, what do you think?

@zhongqishang

Copy link
Copy Markdown
Contributor

@caicancai Thanks for your contribution.

copyright.txt is used with the spotless plugin to generate and validate the copyright of the java/scala file.
What is the reason for remove it?

@caicancai

Copy link
Copy Markdown
Member Author

@caicancai Thanks for your contribution.

copyright.txt is used with the spotless plugin to generate and validate the copyright of the java/scala file. What is the reason for remove it?

I'm not sure about this. I have the impression that many apache projects have deleted this file. According to you, we should keep it. Thank you for your reply.

@zhongqishang

Copy link
Copy Markdown
Contributor

@caicancai Thanks for your contribution.
copyright.txt is used with the spotless plugin to generate and validate the copyright of the java/scala file. What is the reason for remove it?

I'm not sure about this. I have the impression that many apache projects have deleted this file. According to you, we should keep it. Thank you for your reply.

This way can only include java/scala files and does not take effect for other files. I think other projects have been deleted because there is a better way to verify, like flink license_check.sh, or use apache rat plugin, like kyuubi.

I think we should include all files as well.

@caicancai

Copy link
Copy Markdown
Member Author

close first

@caicancai caicancai closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants