Skip to content

Change package name for module core#2767

Merged
zhoujinsong merged 2 commits into
apache:masterfrom
zhoujinsong:change-core-package
Apr 18, 2024
Merged

Change package name for module core#2767
zhoujinsong merged 2 commits into
apache:masterfrom
zhoujinsong:change-core-package

Conversation

@zhoujinsong

@zhoujinsong zhoujinsong commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Change package name to org.apache.amoro for module core.

Brief change log

  • Change package name.
  • Change related docs and configuration files.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions Bot added type:docs Improvements or additions to documentation module:mixed-flink Flink moduel for Mixed Format module:mixed-spark Spark module for Mixed Format module:core Core module module:ams-server Ams server module module:mixed-hive Hive moduel for Mixed Format module:ams-optimizer AMS optimizer module module:mixed-trino trino module for Mixed Format type:infra type:build labels Apr 18, 2024
huyuanfeng2018
huyuanfeng2018 approved these changes Apr 18, 2024
View reviewed changes

@huyuanfeng2018 huyuanfeng2018 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhoujinsong zhoujinsong merged commit d844bf0 into apache:master Apr 18, 2024
@zhoujinsong zhoujinsong deleted the change-core-package branch April 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huyuanfeng2018 huyuanfeng2018 huyuanfeng2018 approved these changes

Assignees

No one assigned

Labels

module:ams-optimizer AMS optimizer module module:ams-server Ams server module module:core Core module module:mixed-flink Flink moduel for Mixed Format module:mixed-hive Hive moduel for Mixed Format module:mixed-spark Spark module for Mixed Format module:mixed-trino trino module for Mixed Format type:build type:docs Improvements or additions to documentation type:infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhoujinsong @huyuanfeng2018