Change Arctic to Mixed for class names in module core#2771
Conversation
|
Some configuration items are named with "arctic." at the beginning. should we change them too? |
|
This PR does not change the thrift-related classes and table property keys, so it still maintains compatibility with older versions. |
|
@zhoujinsong Could you resolve the conflict if you had time? |
filter out jersey in hadoop client
Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
I have merged master branch and fixed the conflicts, please task a look. |
czy006
left a comment
There was a problem hiding this comment.
I think some of the key-value configurations should also be amoro and internally compatible. In the future v1.0 we will completely remove this compatibility.WHDY? @zhoujinsong
Yes, we may push forward this in another PR after discussion in the dev mail list. |
|
All class name were changed from |
|
zhongqishang
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution.
Approve first and merge after resolving conflicts.
Why are the changes needed?
Arctic is no longer the name of the project.
In some old classes, Arctic is used to specify the mixed format, and this PR corrects the class names in the core module.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation