Skip to content

[AMORO-2776] Keeping the folder name the same with the artifactId in amoro-mixed-format module#2777

Merged
zhoujinsong merged 1 commit into
apache:masterfrom
xleoken:2776
Apr 24, 2024
Merged

[AMORO-2776] Keeping the folder name the same with the artifactId in amoro-mixed-format module#2777
zhoujinsong merged 1 commit into
apache:masterfrom
xleoken:2776

Conversation

@xleoken

@xleoken xleoken commented Apr 22, 2024

Copy link
Copy Markdown
Member

Why are the changes needed?

Change the folder name of the module to match the artifactId

Close #2776.

Brief change log

Keeping the folder name the same with the artifactId in amoro-mixed-format module.

image

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@xleoken

xleoken commented Apr 22, 2024

Copy link
Copy Markdown
Member Author

cc @zhoujinsong @zhongqishang

@zhongqishang zhongqishang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are paths used in deployment.md, Need to be changed together.

@github-actions github-actions Bot added the type:docs Improvements or additions to documentation label Apr 23, 2024
@xleoken

xleoken commented Apr 23, 2024

Copy link
Copy Markdown
Member Author

There are paths used in deployment.md, Need to be changed together.

Make sense, updated.

Comment thread docs/admin-guides/deployment.md Outdated

@zhongqishang zhongqishang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 970127e into apache:master Apr 24, 2024
@xleoken xleoken deleted the 2776 branch June 4, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:build type:docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Keeping the folder name the same with the artifactId in amoro-mixed-format module

3 participants