Skip to content

[AMORO-2802] Change the folder name of optimizer module#2804

Merged
zhoujinsong merged 1 commit into
apache:masterfrom
zhongqishang:change-optimizer-folder
May 7, 2024
Merged

[AMORO-2802] Change the folder name of optimizer module#2804
zhoujinsong merged 1 commit into
apache:masterfrom
zhongqishang:change-optimizer-folder

Conversation

@zhongqishang

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Close #2802 .

Brief change log

  • Add prefix amoro
  • Keep the same with module and folder name

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions Bot added type:docs Improvements or additions to documentation module:ams-optimizer AMS optimizer module type:infra type:build labels Apr 30, 2024
@zhongqishang zhongqishang marked this pull request as ready for review April 30, 2024 05:39
@xleoken

xleoken commented May 6, 2024

Copy link
Copy Markdown
Member

lgtm

@zhoujinsong

Copy link
Copy Markdown
Contributor

Hi,

We used to say Flink optimizer/Spark optimizer. So do you think amoro-flink-optimizer/amoro-spark-optimizer is a proper name for both the artifact id and the folder name?

@zhongqishang

Copy link
Copy Markdown
Contributor Author

Hi,

We used to say Flink optimizer/Spark optimizer. So do you think amoro-flink-optimizer/amoro-spark-optimizer is a proper name for both the artifact id and the folder name?

@zhoujinsong @xleoken

Yes, we used to say Flink/Spark optimizer, in order to maintain the unity of the module format, I looked at the flink connector.
Like the structure of flink connector, the module name does not affect us calling it flink kafka connector[1].

[1] : https://github.com/apache/flink-connector-kafka

@xleoken

xleoken commented May 7, 2024

Copy link
Copy Markdown
Member

hi @zhongqishang @zhoujinsong

We can keep the style as amoro-mixed-format module, so amoro-optimizer-flink and amoro-optimizer-spark is ok.

amoro-mixed-format

  • amoro-mixed-format-flink
  • amoro-mixed-format-hive
  • amoro-mixed-format-spark
  • amoro-mixed-format-trino

@zhoujinsong zhoujinsong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me.

@zhoujinsong zhoujinsong merged commit beb878e into apache:master May 7, 2024
@zhongqishang zhongqishang deleted the change-optimizer-folder branch October 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-optimizer AMS optimizer module type:build type:docs Improvements or additions to documentation type:infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Add prefix amoro- for optimizer module and keep same with folder

3 participants