Skip to content

[AMORO-1744] Rename the name of classes with the arctic identifier in the mixed-format-trino module#2836

Closed
xleoken wants to merge 1 commit into
apache:masterfrom
xleoken:rename2
Closed

[AMORO-1744] Rename the name of classes with the arctic identifier in the mixed-format-trino module#2836
xleoken wants to merge 1 commit into
apache:masterfrom
xleoken:rename2

Conversation

@xleoken

@xleoken xleoken commented May 15, 2024

Copy link
Copy Markdown
Member

Why are the changes needed?

Close #1744

Brief change log

Rename the name of classes with the arctic identifier in the mixed-format-trino module

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions Bot added the module:mixed-trino trino module for Mixed Format label May 15, 2024
@zhoujinsong

zhoujinsong commented May 16, 2024

Copy link
Copy Markdown
Contributor

@xleoken Thanks for the contribution.

But I don't think renaming arctic to amoro in all places is a good solution here.
The new project name amoro means a lot more than just the mixed-format now.
So I tried to resolve this issue by #2838, can you help to review it?

@xleoken xleoken closed this May 16, 2024
@xleoken

xleoken commented May 16, 2024

Copy link
Copy Markdown
Member Author

@xleoken Thanks for the contribution.

But I don't think renaming arctic to amoro in all places is a good solution here. The new project name amoro means a lot more than just the mixed-format now. So I tried to resolve this issue by #2838, can you help to review it?

Got.

@xleoken xleoken deleted the rename2 branch June 4, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:mixed-trino trino module for Mixed Format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Rename project from Arctic to Amoro

2 participants